fix(insights): strip sql comments without trailing newline #4493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this case when investigating projects emitting high cardinality metrics. SQL comments that did not end in a newline aren't being stripped correctly. Updated the comment-matching regex to additionally match comments up to the end of the haystack.
Note that there's an interesting interaction with the regexes that meant that the test
already passed without these changes, while the version with the named limit param (
LIMIT %(param_1)s
) did not.