feat(cogs): Track categories in COGS #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/cogs-sub
branch
4 times, most recently
from
ad48747 to
c804364
Compare
Dav1dde
force-pushed
the
dav1d/cogs-sub
branch
from
c804364 to
a4d1fa8
Compare
Dav1dde
force-pushed
the
dav1d/cogs-sub
branch
from
a4d1fa8 to
e5ef35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to split a COGS measurement into multiple categories.
Also instruments the transaction processing with more categories. The initial plan was to instrument normalization in multiple smaller categories, I decided against that in this PR because that requires an API change with huge effects in tests. If we realize normalization takes up a significant amount, we can revisit this.
Ref: https://github.com/getsentry/team-ingest/issues/637
#skip-changelog