Upgrade to rrweb v2 #103
Closed
Upgrade to rrweb v2 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
force-pushed
the
sentry-v2
branch
6 times, most recently
from
ef69398 to
413210e
Compare
|
@mydea not sure the best way to review this, but plan should be to:
I was trying to turn the snapshot tests into explicit assertions but it wasn't that much better (especially when tests fail, it was hard to see what failed). |
mydea
reviewed
Aug 8, 2023
mydea
reviewed
Aug 8, 2023
mydea
reviewed
Aug 8, 2023
mydea
reviewed
Aug 8, 2023
billyvg
force-pushed
the
sentry-v2
branch
4 times, most recently
from
6ad5f67 to
03eba41
Compare
…ded inputs (mutation vs snapshot)
Applying Justin's review suggestion
Add an option to `assertSnapshots` to include scrolling as well for tests that is testing for it.
Merged
billyvg
added a commit
that referenced
this pull request
Sep 21, 2023
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <[email protected]> Co-authored-by: mdellanoce <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <[email protected]> Co-authored-by: mdellanoce <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
Brings this library up to date w/ upstream. Includes additional commits for enhanced privacy and Sentry release workflows. Cherry picks include the following upstream PRs: * rrweb-io#1096 * rrweb-io#1155 * rrweb-io#1257 * rrweb-io#1262 Cherry picks from getsentry fork: * #70 * #103 * 064d8c4 * e274f88 * cffefa2 * #20 --------- Co-authored-by: Michael Dellanoce <[email protected]> Co-authored-by: mdellanoce <[email protected]> Co-authored-by: Yun Feng <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks the following upstream PRs:
ignoreSelectoroption rrweb-io/rrweb#1262Cherry picks from getsentry fork:
onMutationoption torecord#70