ref(repo): Add @sentry-internal namespace to rrweb package names
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jan 19, 2023
| @@ -55,6 +55,7 @@ for (let config of baseConfigs) { | |||
| name: config.name, | |||
| format: 'iife', | |||
| file: pkg.unpkg.replace(pkg.name, config.path), | |||
| extend: true, | |||
There was a problem hiding this comment.
This is the only deliberate change I made: After changing the namespace, rollup threw an error that the package name is illegal unless I add this option. Tbh I'm not entirely sure what the problem here is but I don't think we need this particular build config anyway.
|
Hmm looks like prettier wasn't run on a lot of files... should we discard the autoformat changes? |
Lms24
changed the title
@sentry-internal namespace to rrweb package names
mydea
reviewed
Jan 19, 2023
|
Looks good to me! IMHO we can merge the prettier stuff as well, otherwise it'll come at a later point. Or, maybe we make one PR first with just the prettier changes, then a second one with the package changes? |
Sounds good to me 👍 |
Lms24
force-pushed
the
lms-publish-rename
branch
from
3ef18f5 to
12ba25b
Compare
mydea
approved these changes
Jan 20, 2023
billyvg
approved these changes
Jan 20, 2023
Lms24
added a commit
that referenced
this pull request
Jan 23, 2023
rename the rrweb packages by prepending our `@sentry-internal` namespace. I opted to take the internal one over the usual @sentry namespace as I find it more fitting for the purpose we want to release these packages for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the rrweb packages by prepending our
@sentry-internalnamespace. I opted to take the internal one over the usual @sentry namespace as I find it more fitting for the purpose we want to release these packages for.Note: I'm opening this PR against a
publish-forkbranch so we can continue adding fixes and patching rrweb manually until these packages are released.ref #15