-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quite confusing log message #2137
Comments
strange – I thought I was only printing this when the two URLs are different, but I will double check |
Okay, looks like in one of the places we emit this message we check whether the URLs are different, but in the other spot, we don't: Lines 74 to 83 in 288382f
Should be a pretty simple fix to add this check, thanks for raising @lforst! |
Hey, just got this message as well when configuring Sentry. Let me know when its solved. Thanks! |
@dmadridy hopefully we will get a fix out this week! |
Previously, we warned about a mismatch between the auth token URL and the manually configured URL even when they were the same. We also sometimes issued the warning when no URL was manually configured (i.e. when the default https://sentry.io/ was used). Now, we only warn when the two are actually different and we also only warn if a URL was actually manually configured. Fixes #2137
Previously, we warned about a mismatch between the auth token URL and the manually configured URL even when they were the same. We also sometimes issued the warning when no URL was manually configured (i.e. when the default https://sentry.io/ was used). Now, we only warn when the two are actually different and we also only warn if a URL was actually manually configured. Fixes #2137
Previously, we warned about a mismatch between the auth token URL and the manually configured URL even when they were the same. We also sometimes issued the warning when no URL was manually configured (i.e. when the default https://sentry.io/ was used). Now, we only warn when the two are actually different and we also only warn if a URL was actually manually configured. Fixes #2137
yeesh... What is the actual patch and what does this mean? I have a repo https://github.com/midday-ai/v1 whose deployment to vercel fails because of this unnecessarily confusing message . Upgrading packages for that repo doesnt fix the issue (it's got
yeesh |
@absolutegravitas The log message is confusing but it should not fail your build. You can basically ignore it. |
@szokeasaurusrex I'm using sentry-cli 2.39.1, however I still get the warning when calling
Note the missing trailing slash in the first url (embedded in token): I created the token via https://example.org/settings/arivo/auth-tokens/new-token/. However, when adding the sentry-cli to my Angular project with
So the workaround is to remove in |
@vonox7 this seems to be a bug/unintended behavior in the Sentry Wizard. If you are providing an auth token which embeds a URL, the Sentry Wizard should preferably avoid specifying any URL in the I will raise this with the correct team Update: discussed with the team. The behavior will likely stay the same in the Sentry Wizard for now due to backwards-compatibility concerns, but we can improve the logic for comparing the URLs in the Sentry CLI. In the meantime, you can safely ignore this warning. |
I am getting this in our Changelog Vercel logs. https://vercel.com/sentry/changelog/DT2tEb1huCLLTUm7DzDaWawhZHzi#L159
IMO, if the manually provided URL, and the URL in the auth token are matching, we should not print this message.
cc @szokeasaurusrex
The text was updated successfully, but these errors were encountered: