ref: Update main to indicate it does not return
#2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentry CLI's `main` function calls `commands::main`, which does not return, since it calls `std::process::exit`. Update the function signature to reflect this.
loewenheim
reviewed
Oct 23, 2024
| @@ -4,6 +4,6 @@ mod config; | |||
| mod constants; | |||
| mod utils; | |||
|
|
|||
| pub fn main() { | |||
| pub fn main() -> ! { | |||
There was a problem hiding this comment.
My understanding is that it is not yet stable as a type, but it is stable when used to indicate that a function never returns, like how I am using it here
loewenheim
approved these changes
Oct 23, 2024
Base automatically changed from
szokeasaurusrex/commands-main-no-return
to
master
October 23, 2024 10:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry CLI's
mainfunction callscommands::main, which does not return, since it callsstd::process::exit. Update the function signature to reflect this.Depends on #2191