build: Remove unused dependencies #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our dependencies are apparently unused, so we can remove them. I identified some of these manually, before realizing that the `cargo udeps` command can find unused dependencies automatically (this functionality is unfortunately not built into Cargo). We should consider adding `cargo udeps` as a CI check to avoid accumulating unused dependencies in the future.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-unused-deps
branch
from
c4a273f to
ed6c409
Compare
loewenheim
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our dependencies are apparently unused, so we can remove them.
I identified some of these manually, before realizing that the
cargo udepscommand can find unused dependencies automatically (this functionality is unfortunately not built into Cargo). We should consider addingcargo udepsas a CI check to avoid accumulating unused dependencies in the future.