ref(chunks): Make ChunkedDifRequest take Cow<str> for name
#2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Dec 4, 2024
loewenheim
approved these changes
Dec 4, 2024
Also, update the `Assemblable` trait, so the `name` function returns `Cow<'_, str>` This refactor will allow `ChunkedDifRequest` to also store owned types for the `name`, making the type more flexible. We will use this ability when implementing `Assemblable` for `ProguardMapping`
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-4
branch
from
90c181b to
2a3565e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, update the
Assemblabletrait, so thenamefunction returnsCow<str>This refactor will allow
ChunkedDifRequestto also store owned types for thename, making the type more flexible. We will use this ability when implementingAssemblableforProguardMapping