Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TTID/TTFD for app start transactions #3471

Closed
Tracked by #3465
philipphofmann opened this issue Dec 1, 2023 · 1 comment · Fixed by #3512
Closed
Tracked by #3465

Fix TTID/TTFD for app start transactions #3471

philipphofmann opened this issue Dec 1, 2023 · 1 comment · Fixed by #3512
Assignees
@philipphofmann
Labels
Platform: Cocoa

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Dec 1, 2023 •
edited
Loading

Description

The TTID/TTFD measurements of app start transactions seem to be off:

CleanShot 2023-12-01 at 10 39 21@2x

The start time of the TTID/TTFD spans should be equal to the app start transaction.
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Dec 1, 2023
This was referenced Dec 1, 2023
Open
Closed
@philipphofmann
Copy link
Member Author

philipphofmann commented Dec 6, 2023 •
edited
Loading

TTFD should be equal or after TTID. We can do this fix in a bugfix release.

@philipphofmann philipphofmann added the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Dec 6, 2023
@philipphofmann philipphofmann moved this from Needs Discussion to Todo in Mobile & Cross Platform SDK Dec 6, 2023
@philipphofmann philipphofmann mentioned this issue Dec 18, 2023
Merged
7 tasks
@philipphofmann philipphofmann removed the Breaking-change should go in a major release (breaks apps, changes default configs in a major way) label Dec 19, 2023
@philipphofmann philipphofmann self-assigned this Dec 19, 2023
@philipphofmann philipphofmann moved this from Todo to In Progress in Mobile & Cross Platform SDK Dec 19, 2023
philipphofmann added a commit that referenced this issue Dec 19, 2023
@philipphofmann
fix: TTID/TTFD for app start transactions
9605250 
The TTFD/TTID spans and measurements for app start transactions were
wrong, as they didn't include the app start duration. This is fixed now.

Fixes GH-3471
philipphofmann added a commit that referenced this issue Dec 19, 2023
@philipphofmann
fix: TTID/TTFD for app start transactions
512346e 
The TTFD/TTID spans and measurements for app start transactions were
wrong, as they didn't include the app start duration. This is fixed now.

Fixes GH-3471
philipphofmann added a commit that referenced this issue Dec 19, 2023
@philipphofmann
fix: TTID/TTFD for app start transactions
15d217b 
The TTFD/TTID spans and measurements for app start transactions were
wrong, as they didn't include the app start duration. This is fixed now.

Fixes GH-3471
@philipphofmann philipphofmann mentioned this issue Dec 19, 2023
Merged
7 tasks
@philipphofmann philipphofmann moved this from In Progress to Needs Review in Mobile & Cross Platform SDK Dec 19, 2023
philipphofmann added a commit that referenced this issue Dec 20, 2023
@philipphofmann
fix: TTID/TTFD for app start transactions (#3512)
3297d6e 
The TTFD/TTID spans and measurements for app start transactions were
wrong, as they didn't include the app start duration. This is fixed now.

Fixes GH-3471
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Mobile & Cross Platform SDK Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: TTID/TTFD for app start transactions getsentry/sentry-cocoa
1 participant
@philipphofmann