Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Carthage Xcode 14 compatibility issue #2636

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Conversation

philipphofmann
Copy link
Member

📜 Description

Build XCFramework with Xcode 14.2, use BUILD_LIBRARY_FOR_DISTRIBUTION, and validate that Xcode 14 and 13 can compile the sample project using the XCFramework.

💡 Motivation and Context

Fixes GH-2628

💚 How did you test it?

CI.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Build XCFramework with Xcode 14.2, use BUILD_LIBRARY_FOR_DISTRIBUTION,
and validate that Xcode 14 and 13 can compile the sample project using
the XCFramework.

Fixes GH-2628
@philipphofmann philipphofmann changed the title fix: Carthage Xcode compatibility issue fix: Carthage Xcode 14 compatibility issue Jan 19, 2023
@philipphofmann philipphofmann merged commit 7fb7afb into main Jan 20, 2023
@philipphofmann philipphofmann deleted the fix/carthage branch January 20, 2023 13:22
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Carthage Xcode 14 compatibility issue ([#2636](https://github.com/getsentry/sentry-cocoa/pull/2636))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against b624099

philipphofmann added a commit that referenced this pull request Jan 23, 2023
Build XCFramework with Xcode 14.2, use BUILD_LIBRARY_FOR_DISTRIBUTION,
and validate that Xcode 14 and 13 can compile the sample project using
the XCFramework.

Fixes GH-2628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Module compiled with Swift 5.7 cannot be imported by the Swift 5.7.2 compiler
2 participants