Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Session Replay): Prepare Session event #3693

Merged
merged 30 commits into from
Mar 5, 2024

Conversation

brustolin
Copy link
Contributor

Handling session event during prepareEvent.

#skip-changelog

@brustolin brustolin requested review from romtsn and vaind February 29, 2024 16:03
Copy link

github-actions bot commented Feb 29, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 886c6ec

Copy link

github-actions bot commented Feb 29, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.78 ms 1254.69 ms 22.91 ms
Size 21.58 KiB 430.64 KiB 409.06 KiB

Previous results on branch: feat(SR)/prepare-event

Startup times

Revision Plain With Sentry Diff
2ac1467 1227.74 ms 1246.00 ms 18.26 ms

App size

Revision Plain With Sentry Diff
2ac1467 21.58 KiB 430.65 KiB 409.06 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests for this would be nice. If they already exist, LTGM. Otherwise, please add some.

Base automatically changed from feat(SR)/data-for-replayrecording to feat/session-replay March 1, 2024 10:28
@brustolin brustolin merged commit 9bcf1e7 into feat/session-replay Mar 5, 2024
68 checks passed
@brustolin brustolin deleted the feat(SR)/prepare-event branch March 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants