Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Session Replay): Experimental Options #3816

Merged
merged 20 commits into from
Apr 10, 2024

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Apr 2, 2024

📜 Description

Relates to:

Added and experimental sub option to SentryOption to expose experimental features

#skip-changelog

Copy link

github-actions bot commented Apr 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b3b32b8

@brustolin brustolin changed the title feat: Experimental Options feat(Session Replay): Experimental Options Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 90.09009% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 89.055%. Comparing base (1a1405f) to head (e715ec0).

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feat(SR)/replay-integration     #3816       +/-   ##
=================================================================
+ Coverage                       88.766%   89.055%   +0.289%     
=================================================================
  Files                              554       556        +2     
  Lines                            60141     60379      +238     
  Branches                         21526     21663      +137     
=================================================================
+ Hits                             53385     53771      +386     
+ Misses                            5749      5668       -81     
+ Partials                          1007       940       -67     
Files Coverage Δ
Sources/Sentry/SentryBaseIntegration.m 96.350% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 97.698% <100.000%> (-0.010%) ⬇️
Sources/Sentry/SentrySessionReplayIntegration.m 87.500% <100.000%> (-0.193%) ⬇️
Sources/Swift/SentryExperimentalOptions.swift 100.000% <100.000%> (ø)
...onReplay/SentrySessionReplayIntegrationTests.swift 100.000% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 98.000% <100.000%> (+0.362%) ⬆️
Tests/SentryTests/SentryOptionsTest.m 97.821% <100.000%> (-0.003%) ⬇️
Sources/Sentry/SentrySessionReplay.m 86.227% <86.956%> (+3.874%) ⬆️
...egrations/SessionReplay/SentryOnDemandReplay.swift 7.432% <0.000%> (-0.051%) ⬇️
...tegrations/SessionReplay/SentryReplayOptions.swift 68.421% <50.000%> (-9.357%) ⬇️

... and 76 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1405f...e715ec0. Read the comment docs.

Copy link

github-actions bot commented Apr 3, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.39 ms 1245.63 ms 31.24 ms
Size 21.58 KiB 579.56 KiB 557.98 KiB

Baseline results on branch: feat(SR)/replay-integration

Startup times

Revision Plain With Sentry Diff
a90f1ad 1218.00 ms 1236.04 ms 18.04 ms
f578a85 1196.49 ms 1211.60 ms 15.11 ms
e0754d5 1235.65 ms 1252.04 ms 16.39 ms
dd01832 1214.80 ms 1227.48 ms 12.68 ms
0ab9fa3 1231.39 ms 1252.20 ms 20.82 ms
dd705a9 1202.49 ms 1225.38 ms 22.89 ms
305cf66 1201.24 ms 1217.76 ms 16.51 ms
c203967 1208.16 ms 1225.16 ms 17.00 ms
65442f4 1226.58 ms 1240.06 ms 13.48 ms
6ce4076 1237.80 ms 1250.39 ms 12.59 ms

App size

Revision Plain With Sentry Diff
a90f1ad 21.58 KiB 577.42 KiB 555.84 KiB
f578a85 21.58 KiB 433.83 KiB 412.25 KiB
e0754d5 21.58 KiB 576.65 KiB 555.07 KiB
dd01832 21.58 KiB 576.64 KiB 555.05 KiB
0ab9fa3 21.58 KiB 576.60 KiB 555.01 KiB
dd705a9 21.58 KiB 440.43 KiB 418.85 KiB
305cf66 21.58 KiB 440.48 KiB 418.90 KiB
c203967 21.58 KiB 439.79 KiB 418.21 KiB
65442f4 21.58 KiB 576.63 KiB 555.05 KiB
6ce4076 21.58 KiB 576.86 KiB 555.28 KiB

Previous results on branch: feat/experimental-options

Startup times

Revision Plain With Sentry Diff
23c1156 1218.55 ms 1242.84 ms 24.28 ms
8ba1afe 1232.96 ms 1247.94 ms 14.98 ms
1ca681c 1230.61 ms 1252.46 ms 21.85 ms
42535e4 1231.21 ms 1250.35 ms 19.14 ms
bc9c60d 1235.55 ms 1252.02 ms 16.47 ms
16172e3 1225.07 ms 1241.80 ms 16.73 ms

App size

Revision Plain With Sentry Diff
23c1156 21.58 KiB 577.78 KiB 556.20 KiB
8ba1afe 21.58 KiB 578.58 KiB 557.00 KiB
1ca681c 21.58 KiB 578.08 KiB 556.50 KiB
42535e4 21.58 KiB 577.78 KiB 556.20 KiB
bc9c60d 21.58 KiB 577.78 KiB 556.20 KiB
16172e3 21.58 KiB 577.80 KiB 556.21 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sources/Sentry/Public/SentryOptions.h Outdated Show resolved Hide resolved
Sources/Sentry/SentryOptions.m Outdated Show resolved Hide resolved
brustolin and others added 3 commits April 10, 2024 10:15
Add options to enable or disabled redaction for session replay
@brustolin brustolin merged commit 1f8f703 into feat(SR)/replay-integration Apr 10, 2024
43 of 45 checks passed
@brustolin brustolin deleted the feat/experimental-options branch April 10, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants