-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Session Replay): Experimental Options #3816
feat(Session Replay): Experimental Options #3816
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat(SR)/replay-integration #3816 +/- ##
=================================================================
+ Coverage 88.766% 89.055% +0.289%
=================================================================
Files 554 556 +2
Lines 60141 60379 +238
Branches 21526 21663 +137
=================================================================
+ Hits 53385 53771 +386
+ Misses 5749 5668 -81
+ Partials 1007 940 -67
... and 76 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a90f1ad | 1218.00 ms | 1236.04 ms | 18.04 ms |
f578a85 | 1196.49 ms | 1211.60 ms | 15.11 ms |
e0754d5 | 1235.65 ms | 1252.04 ms | 16.39 ms |
dd01832 | 1214.80 ms | 1227.48 ms | 12.68 ms |
0ab9fa3 | 1231.39 ms | 1252.20 ms | 20.82 ms |
dd705a9 | 1202.49 ms | 1225.38 ms | 22.89 ms |
305cf66 | 1201.24 ms | 1217.76 ms | 16.51 ms |
c203967 | 1208.16 ms | 1225.16 ms | 17.00 ms |
65442f4 | 1226.58 ms | 1240.06 ms | 13.48 ms |
6ce4076 | 1237.80 ms | 1250.39 ms | 12.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a90f1ad | 21.58 KiB | 577.42 KiB | 555.84 KiB |
f578a85 | 21.58 KiB | 433.83 KiB | 412.25 KiB |
e0754d5 | 21.58 KiB | 576.65 KiB | 555.07 KiB |
dd01832 | 21.58 KiB | 576.64 KiB | 555.05 KiB |
0ab9fa3 | 21.58 KiB | 576.60 KiB | 555.01 KiB |
dd705a9 | 21.58 KiB | 440.43 KiB | 418.85 KiB |
305cf66 | 21.58 KiB | 440.48 KiB | 418.90 KiB |
c203967 | 21.58 KiB | 439.79 KiB | 418.21 KiB |
65442f4 | 21.58 KiB | 576.63 KiB | 555.05 KiB |
6ce4076 | 21.58 KiB | 576.86 KiB | 555.28 KiB |
Previous results on branch: feat/experimental-options
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
23c1156 | 1218.55 ms | 1242.84 ms | 24.28 ms |
8ba1afe | 1232.96 ms | 1247.94 ms | 14.98 ms |
1ca681c | 1230.61 ms | 1252.46 ms | 21.85 ms |
42535e4 | 1231.21 ms | 1250.35 ms | 19.14 ms |
bc9c60d | 1235.55 ms | 1252.02 ms | 16.47 ms |
16172e3 | 1225.07 ms | 1241.80 ms | 16.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
23c1156 | 21.58 KiB | 577.78 KiB | 556.20 KiB |
8ba1afe | 21.58 KiB | 578.58 KiB | 557.00 KiB |
1ca681c | 21.58 KiB | 578.08 KiB | 556.50 KiB |
42535e4 | 21.58 KiB | 577.78 KiB | 556.20 KiB |
bc9c60d | 21.58 KiB | 577.78 KiB | 556.20 KiB |
16172e3 | 21.58 KiB | 577.80 KiB | 556.21 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A session can't be longer than 60 minutes.
Add options to enable or disabled redaction for session replay
1f8f703
into
feat(SR)/replay-integration
📜 Description
Relates to:
Added and experimental sub option to SentryOption to expose experimental features
#skip-changelog