feat: sentry.properties

[buenaflor]

📜 Description

Add sentry.properties for additional config options.

it tries to load sentry.properties first and if it doesn't exist it will fallback to pubspec.yaml

💡 Motivation and Context

Closes #42

💚 How did you test it?

Unit test
Manually

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• I updated the docs if needed
• All tests passing
• No breaking changes

🔮 Next steps

• Add sentry docs

[github-actions]

	Fails
🚫	Please consider adding a changelog entry for the next release.

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- sentry.properties ([#191](https://github.com/getsentry/sentry-dart-plugin/pull/191))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 443aa60

[krystofwoldrich]

I don't have any comment on the code, that looks good to me.

I'm a bit concerned if this is not a breaking feature given the order we read the configs. If sentry.properties in the root of a Flutter project has not been used for anything till now, it should be fine.

I think the safer order would be to try first pubspec.yaml then sentry.properties then env. Although a bit more complex I would expect these two configs can coexist.

That would allow users to hide sensitive config to the properties file and then not commit it for example. Maybe not necessary.

[buenaflor]

Hm good point, at the very least it should be pubspec first and then sentry.properties.

Although a bit more complex I would expect these two configs can coexist.

Managing sensitive config can also be managed through env variables that can be added to sentry.properties afaik, gotta check if that works

Will go with the co-existing config route, will check out gradle plugin to see how they handle it

[buenaflor]

@krystofwoldrich it seems like sentry.properties on the gradle plugin only uses org, project and auth-token so I think using sentry.properties as fallback and separating is the way to go. I guess we can adjust our approach based on demand but I think it should be good enough for now

[krystofwoldrich]

@buenaflor I agree, we can adjust based on demand, this solves the current issues and I don't expect high demand for combining the approaches.

[jtmuller5]

How are you supposed to create the sentry.properties file? I tried creating it as a json and as list of values like in pubspec.yaml but it is not recognized by the CLI

[buenaflor]

key=value
# e.g
upload_debug_symbols=true

we'll add docs to the readme for that

• Add docs for sentry.properties