Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload .dart files with upload-sourcemaps when upload_sources is enabled #247

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jul 8, 2024

… is enabled

πŸ“œ Description

  • Only upload .dart files with upload-sourcemaps when upload_sources is enabled

πŸ’‘ Motivation and Context

Relates to #246

πŸ’š How did you test it?

Tests

πŸ“ Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase
Copy link
Collaborator Author

denrase commented Jul 8, 2024

@buenaflor Would still be interesting what the reasoning behind having the dart file upload in the first place.

@buenaflor
Copy link
Contributor

Would still be interesting what the reasoning behind having the dart file upload in the first place.

should be the source context, we probably should mention it that it works as well for flutter web.

https://docs.sentry.io/platforms/flutter/upload-debug/#uploading-source-context-for-flutter-android-ios-and-macos doesn't say that it works on web

@denrase denrase marked this pull request as ready for review July 8, 2024 10:28
@buenaflor
Copy link
Contributor

buenaflor commented Jul 8, 2024

@denrase

This will automatically enable Source Context as well. is under the source maps section

I still think it should be more visible.

Maybe the source context header should be a general header and has subsections based on platform

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments

lib/sentry_dart_plugin.dart Outdated Show resolved Hide resolved
lib/sentry_dart_plugin.dart Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@denrase denrase requested a review from buenaflor July 8, 2024 12:06
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@denrase denrase merged commit 3abd6f3 into main Jul 8, 2024
10 checks passed
@denrase denrase deleted the source-upload-opt-in branch July 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants