-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only upload .dart
files with upload-sourcemaps
when upload_sources
is enabled
#247
Conversation
@buenaflor Would still be interesting what the reasoning behind having the |
should be the source context, we probably should mention it that it works as well for flutter web. https://docs.sentry.io/platforms/flutter/upload-debug/#uploading-source-context-for-flutter-android-ios-and-macos doesn't say that it works on web |
I still think it should be more visible. Maybe the source context header should be a general header and has subsections based on platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
β¦ is enabled
π Description
.dart
files withupload-sourcemaps
whenupload_sources
is enabledπ‘ Motivation and Context
Relates to #246
π How did you test it?
Tests
π Checklist