format

getsentry · Dec 18, 2023 · 2dce393 · 2dce393
1 parent e04bec3
commit 2dce393
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 45 deletions.
diff --git a/flutter/lib/src/integrations/connectivity/connectivity_integration.dart b/flutter/lib/src/integrations/connectivity/connectivity_integration.dart
@@ -34,5 +34,3 @@ class ConnectivityIntegration extends Integration<SentryFlutterOptions> {
     );
   }
 }
-
-
diff --git a/flutter/lib/src/integrations/connectivity/connectivity_provider.dart b/flutter/lib/src/integrations/connectivity/connectivity_provider.dart
@@ -1,6 +1,5 @@
-
 import 'noop_connectivity_provider.dart'
-if (dart.library.html) 'web_connectivity_provider.dart';
+    if (dart.library.html) 'web_connectivity_provider.dart';
 
 abstract class ConnectivityProvider {
   factory ConnectivityProvider() => connectivityProvider();

diff --git a/flutter/lib/src/integrations/connectivity/noop_connectivity_provider.dart b/flutter/lib/src/integrations/connectivity/noop_connectivity_provider.dart
@@ -1,12 +1,10 @@
-
 import 'connectivity_provider.dart';
 
 ConnectivityProvider connectivityProvider() {
   return NoOpConnectivityProvider();
 }
 
 class NoOpConnectivityProvider implements ConnectivityProvider {
-
   @override
   void listen(void Function(String connectivity) onChange) {
     // NoOp

diff --git a/flutter/lib/src/integrations/connectivity/web_connectivity_provider.dart b/flutter/lib/src/integrations/connectivity/web_connectivity_provider.dart
@@ -8,7 +8,6 @@ ConnectivityProvider connectivityProvider() {
 }
 
 class WebConnectivityProvider implements ConnectivityProvider {
-
   StreamSubscription<html.Event>? _onOnlineSub;
   StreamSubscription<html.Event>? _onOfflineSub;
 

diff --git a/flutter/test/integrations/connectivity_integration_test.dart b/flutter/test/integrations/connectivity_integration_test.dart
@@ -32,9 +32,7 @@ void main() {
         true);
   });
 
-  test(
-      '$ConnectivityIntegration: addsBreadcrumb',
-      () {
+  test('$ConnectivityIntegration: addsBreadcrumb', () {
     final integration = fixture.getSut();
     integration.call(fixture.hub, fixture.options);
 

diff --git a/flutter/test/sentry_flutter_test.dart b/flutter/test/sentry_flutter_test.dart
@@ -24,6 +24,10 @@ final platformAgnosticIntegrations = [
   SentryViewHierarchyIntegration,
 ];
 
+final webIntegrations = [
+  ConnectivityIntegration,
+];
+
 final nonWebIntegrations = [
   OnErrorIntegration,
 ];
@@ -44,11 +48,6 @@ final nativeIntegrations = [
   NativeSdkIntegration,
 ];
 
-// These should be added to every platform except Android & iOS/macOS.
-final nonMobileIntegrations = [
-  ConnectivityIntegration,
-];
-
 void main() {
   TestWidgetsFlutterBinding.ensureInitialized();
 
@@ -87,17 +86,17 @@ void main() {
           options: sentryFlutterOptions!, expectedHasNativeScopeObserver: true);
 
       testConfiguration(
-          integrations: integrations,
-          shouldHaveIntegrations: [
-            ...androidIntegrations,
-            ...nativeIntegrations,
-            ...platformAgnosticIntegrations,
-            ...nonWebIntegrations,
-          ],
-          shouldNotHaveIntegrations: [
-            ...iOsAndMacOsIntegrations,
-            ...nonWebIntegrations,
-          ],
+        integrations: integrations,
+        shouldHaveIntegrations: [
+          ...androidIntegrations,
+          ...nativeIntegrations,
+          ...platformAgnosticIntegrations,
+          ...nonWebIntegrations,
+        ],
+        shouldNotHaveIntegrations: [
+          ...iOsAndMacOsIntegrations,
+          ...nonWebIntegrations,
+        ],
       );
 
       integrations
@@ -192,19 +191,15 @@ void main() {
       testScopeObserver(
           options: sentryFlutterOptions!, expectedHasNativeScopeObserver: true);
 
-      testConfiguration(
-        integrations: integrations,
-        shouldHaveIntegrations: [
-          ...iOsAndMacOsIntegrations,
-          ...nativeIntegrations,
-          ...platformAgnosticIntegrations,
-          ...nonWebIntegrations,
-        ],
-        shouldNotHaveIntegrations: [
-          ...androidIntegrations,
-          ...nonWebIntegrations,
-        ]
-      );
+      testConfiguration(integrations: integrations, shouldHaveIntegrations: [
+        ...iOsAndMacOsIntegrations,
+        ...nativeIntegrations,
+        ...platformAgnosticIntegrations,
+        ...nonWebIntegrations,
+      ], shouldNotHaveIntegrations: [
+        ...androidIntegrations,
+        ...nonWebIntegrations,
+      ]);
 
       testBefore(
           integrations: integrations,
@@ -250,12 +245,12 @@ void main() {
         shouldHaveIntegrations: [
           ...platformAgnosticIntegrations,
           ...nonWebIntegrations,
-          ...nonMobileIntegrations,
         ],
         shouldNotHaveIntegrations: [
           ...androidIntegrations,
           ...iOsAndMacOsIntegrations,
           ...nativeIntegrations,
+          ...webIntegrations,
         ],
       );
 
@@ -302,12 +297,12 @@ void main() {
         shouldHaveIntegrations: [
           ...platformAgnosticIntegrations,
           ...nonWebIntegrations,
-          ...nonMobileIntegrations,
         ],
         shouldNotHaveIntegrations: [
           ...androidIntegrations,
           ...iOsAndMacOsIntegrations,
           ...nativeIntegrations,
+          ...webIntegrations,
         ],
       );
 
@@ -356,7 +351,7 @@ void main() {
         integrations: integrations,
         shouldHaveIntegrations: [
           ...platformAgnosticIntegrations,
-          ...nonMobileIntegrations,
+          ...webIntegrations,
         ],
         shouldNotHaveIntegrations: [
           ...androidIntegrations,
@@ -404,7 +399,10 @@ void main() {
 
       testConfiguration(
         integrations: integrations,
-        shouldHaveIntegrations: platformAgnosticIntegrations,
+        shouldHaveIntegrations: [
+          ...platformAgnosticIntegrations,
+          ...webIntegrations,
+        ],
         shouldNotHaveIntegrations: [
           ...androidIntegrations,
           ...iOsAndMacOsIntegrations,
@@ -448,7 +446,10 @@ void main() {
 
       testConfiguration(
         integrations: integrations,
-        shouldHaveIntegrations: platformAgnosticIntegrations,
+        shouldHaveIntegrations: [
+          ...platformAgnosticIntegrations,
+          ...webIntegrations,
+        ],
         shouldNotHaveIntegrations: [
           ...androidIntegrations,
           ...iOsAndMacOsIntegrations,
@@ -493,7 +494,10 @@ void main() {
 
       testConfiguration(
         integrations: integrations,
-        shouldHaveIntegrations: platformAgnosticIntegrations,
+        shouldHaveIntegrations: [
+          ...platformAgnosticIntegrations,
+          ...webIntegrations,
+        ],
         shouldNotHaveIntegrations: [
           ...androidIntegrations,
           ...iOsAndMacOsIntegrations,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -34,5 +34,3 @@ class ConnectivityIntegration extends Integration<SentryFlutterOptions> {
		);
		}
		}
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,7 +8,6 @@ ConnectivityProvider connectivityProvider() { @@
     }
     class WebConnectivityProvider implements ConnectivityProvider {
       StreamSubscription<html.Event>? _onOnlineSub;
       StreamSubscription<html.Event>? _onOfflineSub;
@@ Expand Down @@