-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log errors from PlatformDispatcher #1257
Conversation
This is similar to how the FlutterErrorIntegration prints caught errors.
Thanks @maBarabas |
Codecov ReportBase: 90.03% // Head: 90.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
==========================================
+ Coverage 90.03% 90.65% +0.61%
==========================================
Files 110 144 +34
Lines 3483 4707 +1224
==========================================
+ Hits 3136 4267 +1131
- Misses 347 440 +93
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Should we log at debug level even when |
That's just for console logging, it is fine as it is, and we can change it if necessary. |
📜 Description
This is similar to how the FlutterErrorIntegration prints caught errors.
💡 Motivation and Context
Fixes #1255
💚 How did you test it?
See demo app at linked issue. After this change, enabling debug on Sentry options makes an error show up in the logs for each error reported by the PlatformDispatcher.
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps