-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replay tags #2592
feat: replay tags #2592
Conversation
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2592 +/- ##
==========================================
+ Coverage 89.00% 92.64% +3.64%
==========================================
Files 262 91 -171
Lines 8968 3020 -5948
==========================================
- Hits 7982 2798 -5184
+ Misses 986 222 -764 ☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
905bf99 | 1240.84 ms | 1271.47 ms | 30.63 ms |
cf91c9d | 1217.08 ms | 1233.00 ms | 15.92 ms |
09eab47 | 1246.88 ms | 1267.71 ms | 20.83 ms |
d8519f9 | 1208.57 ms | 1229.80 ms | 21.22 ms |
c1bb00f | 1265.14 ms | 1290.85 ms | 25.71 ms |
0b204c0 | 1232.19 ms | 1244.37 ms | 12.18 ms |
0e0581f | 1250.13 ms | 1278.96 ms | 28.83 ms |
d301b11 | 1260.61 ms | 1272.06 ms | 11.45 ms |
8d64376 | 1260.92 ms | 1289.32 ms | 28.40 ms |
4656f10 | 1247.04 ms | 1276.16 ms | 29.12 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
905bf99 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
cf91c9d | 8.33 MiB | 9.40 MiB | 1.07 MiB |
09eab47 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
d8519f9 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
c1bb00f | 8.09 MiB | 9.07 MiB | 1001.06 KiB |
0b204c0 | 8.42 MiB | 9.84 MiB | 1.41 MiB |
0e0581f | 8.38 MiB | 9.78 MiB | 1.41 MiB |
d301b11 | 8.10 MiB | 9.07 MiB | 1000.82 KiB |
8d64376 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
4656f10 | 8.32 MiB | 9.50 MiB | 1.19 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bdd1a23 | 316.21 ms | 364.80 ms | 48.59 ms |
dd25e43 | 449.40 ms | 504.18 ms | 54.78 ms |
32fa6b6 | 420.38 ms | 497.90 ms | 77.52 ms |
66e0270 | 369.04 ms | 431.96 ms | 62.92 ms |
b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
e2d89fc | 323.84 ms | 376.23 ms | 52.39 ms |
a817b8f | 383.02 ms | 445.17 ms | 62.15 ms |
4c13d97 | 455.34 ms | 509.42 ms | 54.08 ms |
873fb42 | 352.10 ms | 397.43 ms | 45.33 ms |
3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bdd1a23 | 6.16 MiB | 7.14 MiB | 1011.19 KiB |
dd25e43 | 6.46 MiB | 7.48 MiB | 1.02 MiB |
32fa6b6 | 6.35 MiB | 7.35 MiB | 1021.69 KiB |
66e0270 | 6.35 MiB | 7.35 MiB | 1017.84 KiB |
b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
e2d89fc | 6.06 MiB | 7.03 MiB | 989.37 KiB |
a817b8f | 6.16 MiB | 7.14 MiB | 1003.22 KiB |
4c13d97 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
873fb42 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps