Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move application of event processors to shared function #2594

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jan 21, 2025

#skip-changelog

📜 Description

  • Move application of event processors to shared function
  • Also record discard reason for scope event processors

💡 Motivation and Context

Closes #2570

💚 How did you test it?

Existing tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase marked this pull request as ready for review January 21, 2025 12:39
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.82 ms 425.02 ms 15.20 ms
Size 6.46 MiB 7.48 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a758ebd 556.55 ms 588.14 ms 31.59 ms
f0fcbe1 305.77 ms 369.46 ms 63.69 ms
7659cbe 503.66 ms 570.09 ms 66.43 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
5baa201 389.26 ms 462.83 ms 73.57 ms
211a7aa 324.19 ms 393.26 ms 69.07 ms
31b2afb 397.04 ms 475.09 ms 78.04 ms
752e1cb 472.85 ms 511.60 ms 38.76 ms
ee0ca56 355.35 ms 421.13 ms 65.78 ms
9f05645 349.43 ms 437.24 ms 87.81 ms

App size

Revision Plain With Sentry Diff
a758ebd 6.49 MiB 7.57 MiB 1.08 MiB
f0fcbe1 6.16 MiB 7.14 MiB 1009.90 KiB
7659cbe 6.46 MiB 7.48 MiB 1.03 MiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
5baa201 6.35 MiB 7.33 MiB 1005.56 KiB
211a7aa 6.06 MiB 7.03 MiB 997.24 KiB
31b2afb 6.34 MiB 7.28 MiB 966.36 KiB
752e1cb 6.49 MiB 7.57 MiB 1.08 MiB
ee0ca56 6.33 MiB 7.30 MiB 992.52 KiB
9f05645 6.27 MiB 7.20 MiB 958.60 KiB

Previous results on branch: ref/event-processor-deduplication

Startup times

Revision Plain With Sentry Diff
a41f5f4 725.53 ms 815.69 ms 90.16 ms

App size

Revision Plain With Sentry Diff
a41f5f4 6.46 MiB 7.48 MiB 1.02 MiB

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.98%. Comparing base (0965b4f) to head (2f044b8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../lib/src/event_processor/run_event_processors.dart 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
+ Coverage   88.96%   88.98%   +0.02%     
==========================================
  Files         262      263       +1     
  Lines        8941     8940       -1     
==========================================
+ Hits         7954     7955       +1     
+ Misses        987      985       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

just waiting for tests to be green

Copy link
Contributor

github-actions bot commented Jan 22, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.48 ms 1260.31 ms 18.83 ms
Size 8.42 MiB 9.91 MiB 1.49 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e4d5aa8 1224.15 ms 1245.72 ms 21.57 ms
cc80714 1205.53 ms 1223.90 ms 18.37 ms
a80fbd1 1258.06 ms 1273.44 ms 15.38 ms
50bdfad 1253.14 ms 1274.54 ms 21.40 ms
e66e71e 1273.55 ms 1291.63 ms 18.08 ms
636cb61 1266.06 ms 1271.38 ms 5.31 ms
6aab859 1245.14 ms 1247.59 ms 2.45 ms
9e7630d 1246.75 ms 1265.42 ms 18.67 ms
48adddf 1255.76 ms 1280.31 ms 24.55 ms
f922f8f 1249.53 ms 1266.51 ms 16.98 ms

App size

Revision Plain With Sentry Diff
e4d5aa8 8.33 MiB 9.62 MiB 1.29 MiB
cc80714 8.33 MiB 9.40 MiB 1.07 MiB
a80fbd1 8.42 MiB 9.89 MiB 1.46 MiB
50bdfad 8.32 MiB 9.43 MiB 1.10 MiB
e66e71e 8.10 MiB 9.08 MiB 1004.36 KiB
636cb61 8.28 MiB 9.34 MiB 1.06 MiB
6aab859 8.29 MiB 9.36 MiB 1.07 MiB
9e7630d 8.38 MiB 9.78 MiB 1.40 MiB
48adddf 8.28 MiB 9.34 MiB 1.06 MiB
f922f8f 8.15 MiB 9.13 MiB 1003.20 KiB

Previous results on branch: ref/event-processor-deduplication

Startup times

Revision Plain With Sentry Diff
a41f5f4 1248.74 ms 1279.63 ms 30.89 ms

App size

Revision Plain With Sentry Diff
a41f5f4 8.42 MiB 9.91 MiB 1.49 MiB

@buenaflor
Copy link
Contributor

@denrase analyze ci is failing

@denrase
Copy link
Collaborator Author

denrase commented Jan 22, 2025

@buenaflor Unused import, fixed.

@buenaflor buenaflor merged commit c01acd1 into main Jan 22, 2025
150 checks passed
@buenaflor buenaflor deleted the ref/event-processor-deduplication branch January 22, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deduplicate event-processor calls
2 participants