Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning if the rate limit was reached #2595

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jan 21, 2025

📜 Description

  • Log a warning if 429 rate limit header is received in HttpTransport

💡 Motivation and Context

Closes #2551

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase marked this pull request as ready for review January 21, 2025 13:14
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (1c926c2) to head (83b0c17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
+ Coverage   88.98%   89.00%   +0.02%     
==========================================
  Files         262      262              
  Lines        8966     8968       +2     
==========================================
+ Hits         7978     7982       +4     
+ Misses        988      986       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 453.06 ms 517.81 ms 64.75 ms
Size 6.46 MiB 7.48 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
64e4616 349.82 ms 436.96 ms 87.14 ms
deaeece 347.42 ms 381.10 ms 33.68 ms
689d2fd 378.62 ms 430.48 ms 51.86 ms
ab0eee1 457.78 ms 498.98 ms 41.20 ms
051e97a 359.56 ms 426.68 ms 67.12 ms
a775d3f 359.58 ms 436.68 ms 77.10 ms
68677de 364.41 ms 415.61 ms 51.20 ms
ed2ae08 360.06 ms 440.92 ms 80.86 ms
6f3717a 359.20 ms 422.88 ms 63.67 ms
dd933d4 381.43 ms 471.57 ms 90.15 ms

App size

Revision Plain With Sentry Diff
64e4616 6.27 MiB 7.20 MiB 956.52 KiB
deaeece 5.94 MiB 6.96 MiB 1.02 MiB
689d2fd 6.06 MiB 7.10 MiB 1.04 MiB
ab0eee1 6.49 MiB 7.56 MiB 1.07 MiB
051e97a 6.27 MiB 7.20 MiB 959.09 KiB
a775d3f 6.27 MiB 7.20 MiB 957.75 KiB
68677de 6.06 MiB 7.10 MiB 1.04 MiB
ed2ae08 6.27 MiB 7.20 MiB 958.73 KiB
6f3717a 6.35 MiB 7.35 MiB 1017.82 KiB
dd933d4 6.35 MiB 7.35 MiB 1021.70 KiB

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@denrase denrase merged commit 8bac8ba into main Jan 21, 2025
149 of 150 checks passed
@denrase denrase deleted the enha/additional-rate-limit-logging branch January 21, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants