-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9]: Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 #2643
Conversation
# Conflicts: # .github/workflows/dart.yml # dart/test/run_zoned_guarded_integration_test.dart # flutter/lib/src/sentry_asset_bundle.dart # flutter/lib/src/sentry_flutter.dart # flutter/test/screenshot/sentry_screenshot_widget_test.dart
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good on first pass 👍
will have another look later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have another library added now link
, you can change the versions there too
You can also get rid of this compatibility code: sentry-dart/flutter/lib/src/event_processor/flutter_enricher_event_processor.dart Lines 274 to 279 in a24a1db
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2643 +/- ##
===========================================
+ Coverage 67.94% 89.17% +21.22%
===========================================
Files 15 263 +248
Lines 443 8924 +8481
===========================================
+ Hits 301 7958 +7657
- Misses 142 966 +824 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CHANGELOG.md
Outdated
@@ -393,6 +393,10 @@ | |||
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#7181) | |||
- [diff](https://github.com/getsentry/sentry-java/compare/7.18.0...7.18.1) | |||
|
|||
## 9.0.0 | |||
|
|||
- Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) | |
- Increase minimum SDK version requirements to Dart v3.5.0 and Flutter v3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643)) |
📜 Description
💡 Motivation and Context
Closes #2626
💚 How did you test it?
CI
📝 Checklist
sendDefaultPii
is enabled