Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(javascript): Default to browsernpm over browser CDN #1002

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented May 23, 2019

By default in the sentry wizard clicking 'javascript' gives you the CDN version. I would argue that most people these days likely want the yarn/npm version.

@evanpurkhiser evanpurkhiser requested a review from dcramer May 23, 2019 23:09
@dcramer
Copy link
Member

dcramer commented May 24, 2019

im neutral on this as im not really sure thats true, and seems fairly subjective

certainly for certain platforms it is (e.g. react)

@benvinegar
Copy link
Contributor

I know that when I'm quickly messing around with Sentry I just whip together a static web page and use the CDN example.

I think copy/pasting is more approachable (a lot of websites/apps out there that don't use Webpack, Babel, etc.) and we should stick to that. We can always have a callout.

Otherwise I think we need to look at some kind of metric/stats to make an intelligent decision here.

@evanpurkhiser
Copy link
Member Author

I think what we can do is have a 'ES6' option that lives right next to the Javascript option (or something line that) since right now we don't show both in the wizards 'popular' menu

image

@evanpurkhiser evanpurkhiser deleted the refjavascript-default-to-browsernpm-over-browser-cdn branch May 28, 2019 22:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants