Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(symfony): Add example of triggering an error #1007

Merged
merged 1 commit into from
May 29, 2019

Conversation

evanpurkhiser
Copy link
Member

No description provided.


```php
/**
* @Route("/debug-sentry")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that annotations are included in the default app setup for symfony4 applications. Defining routes in a yaml file is another option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd like to not have two separate code blocks.

Would we be okay showing this as the example and letting users decide how they want to configure the routing themselves?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony folks will have at least seen this style of routing before and know how to translate that int the syntax they use.

@evanpurkhiser evanpurkhiser requested a review from markstory May 28, 2019 23:02
@evanpurkhiser evanpurkhiser merged commit 4eae257 into master May 29, 2019
@evanpurkhiser evanpurkhiser deleted the refsymfony-add-example-of-triggering-an-error branch May 29, 2019 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants