Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo when calling the SDK #1083

Closed
wants to merge 1 commit into from
Closed

Typo when calling the SDK #1083

wants to merge 1 commit into from

Conversation

B-Galati
Copy link

I just had this issue when I was setting up the SDK.

Let me know if I am correct and I will fix it everywhere else.

Cheers!

@untitaker
Copy link
Member

🤔 e6c1252

@untitaker untitaker requested a review from HazAT June 30, 2019 12:03
@B-Galati
Copy link
Author

B-Galati commented Jul 1, 2019

Sorry I made a typo it's Sentry with an uppercase S.

Regarding the answer, at the moment if you copy/paste the given code from the doc it will not work without the leading \ and that is a pity TBH.

@ste93cry
Copy link
Contributor

ste93cry commented Jul 1, 2019

if you copy/paste the given code from the doc it will not work without the leading \ and that is a pity TBH

The example supposes that you're code is not namespaced and so there is no need to prefix the use statement with \. However, if you are willing to update all the code samples to have the leading \ it would be more than welcome since that way the code will work for both cases (namespaced and not)

ste93cry
ste93cry suggested changes Jul 1, 2019
View reviewed changes
src/collections/_documentation/error-reporting/getting-started-config/php.md
@@ -1,5 +1,5 @@
To capture all errors, even the one during the startup of your application, you should initialize the Sentry PHP SDK as soon as possible.

```php
Sentry\init(['dsn' => '___PUBLIC_DSN___' ]);
\sentry\init(['dsn' => '___PUBLIC_DSN___' ]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, the S must be uppercase

@B-Galati
Copy link
Author

B-Galati commented Jul 1, 2019 •
edited
Loading

I will. Thank you for your feedback.

@HazAT
Copy link
Member

HazAT commented Oct 9, 2019

I closing this since it has become stale and it is already fixed.

@HazAT HazAT closed this Oct 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ste93cry ste93cry ste93cry requested changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@B-Galati @untitaker @ste93cry @HazAT