Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo's, import, ... in React docs #1095

Merged
merged 6 commits into from
Jul 3, 2019

Conversation

JonathanCallewaert
Copy link
Contributor

  • Add an import
  • Change scope.setExtras(errorInfo) to scope.setExtra(errorInfo)
  • use getDerivedStateFromError to indicate an error occurred ( React uses getDerivedStateFromError ) in their docs also
  • Change anchor element to button element as ESLint will give warning because you don't use an href attribute

- Add an import
- Change scope.setExtras(errorInfo) to scope.setExtra(errorInfo)
- use getDerivedStateFromError to indicate an error occurred ( React uses getDerivedStateFromError ) in their docs also
- Change anchor element to button element as ESLint will give warning because you don't use an href attribute
@JonathanCallewaert JonathanCallewaert changed the title Fix typo's, import, ... Fix typo's, import, ... in React docs Jul 3, 2019
@dashed dashed self-requested a review July 3, 2019 06:03
@dashed
Copy link
Member

dashed commented Jul 3, 2019

@JonathanCA97 thanks!

There's a similar PR at #1040 which I've been meaning to review; but haven't gotten around to doing it yet 😅

@JonathanCallewaert
Copy link
Contributor Author

@dashed oh sorry I didn't saw it! I can add the changes of #1040 that I haven't in my PR if you want ?

@JonathanCallewaert
Copy link
Contributor Author

@dashed I updated it ;)

const eventId = Sentry.captureException(error);
this.setState({ eventId });
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here looks inconsistent with other parts of the code in the same class, could we get that straightened out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markstory yes indeed, I fixed it

@dashed dashed merged commit df5543d into getsentry:master Jul 3, 2019
@dashed
Copy link
Member

dashed commented Jul 3, 2019

@JonathanCA97 thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants