-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo's, import, ... in React docs #1095
Conversation
JonathanCallewaert
commented
Jul 3, 2019
- Add an import
- Change scope.setExtras(errorInfo) to scope.setExtra(errorInfo)
- use getDerivedStateFromError to indicate an error occurred ( React uses getDerivedStateFromError ) in their docs also
- Change anchor element to button element as ESLint will give warning because you don't use an href attribute
- Add an import - Change scope.setExtras(errorInfo) to scope.setExtra(errorInfo) - use getDerivedStateFromError to indicate an error occurred ( React uses getDerivedStateFromError ) in their docs also - Change anchor element to button element as ESLint will give warning because you don't use an href attribute
@JonathanCA97 thanks! There's a similar PR at #1040 which I've been meaning to review; but haven't gotten around to doing it yet 😅 |
@dashed I updated it ;) |
const eventId = Sentry.captureException(error); | ||
this.setState({ eventId }); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation here looks inconsistent with other parts of the code in the same class, could we get that straightened out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markstory yes indeed, I fixed it
Co-Authored-By: Alberto Leal <[email protected]>
@JonathanCA97 thanks! |