feat: Banner pathname regex #11761
Merged
feat: Banner pathname regex #11761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 1.15kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
a-hariti
requested review from
elijames-codecov,
chargome and
stephanie-anderson
chargome
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Nice approach! Just some UI issues I noticed when looking at the banner example in /platforms/javascript/:
- padding seems too small
- font size is slightly larger than on the banner on welcome page
- dark mode should not change the font color if the background stays the same
- banner is not responding well on mobile
|
I was about to write that we need to check if this approach (regex) is suitable for the target audience - but it seems this is what they already do in static-pages :) Please make sure to document it in the contribution guide (would not rely on the comments in code) |
|
I think the home page banner is the one that needs to be obvious, other will probably be set by devs and |
chargome
approved these changes
Nov 8, 2024
martinhaintz
pushed a commit
that referenced
this pull request
Nov 11, 2024
* master: (39 commits) getsentry/relay@403f2bf feat(native): add backend trade-offs to Advanced Usage (#11721) 🔧 chore(api): add additional troubleshooting instructions to publish api docs (#11772) Bump API schema to 02adb960 (#11773) Update metric-alert-config.mdx (#11760) update w-9 tax form (#11764) chore: silence fetch cache error due to size limit (#11767) fix Ureal engine DSN placeholder (#11769) feat: Banner pathname regex (#11761) docs(nuxt): Add troubleshoot pnpm (#11720) Docker Desktop to Colima fix (#11752) Bump API schema to d51784a6 (#11759) ref(feedback): update user feedback docs to include external issue linking & auto issue creation (#11729) getsentry/relay@d23c39a Changed /store to /envelope (because /store does not exist anymore (#11755) Refactor arcade embeds (#11722) feat(js): Add `skipBrowserExtensionCheck` documentation (#11693) getsentry/relay@a7d9096 fix mermaid charts in dark mode (#11754) fix: Log4j configurations and wording (#11395) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple banners along with Regex pathname matching and expiration dates
closes #11532
TODO