Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(flutter): Use sentry flutter init in samples #11858

Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Nov 18, 2024

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Add samples that use SentryFlutter.init instead of Sentry.init.

Relates to getsentry/sentry-dart#2383

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Nov 18, 2024

@denrase is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@denrase denrase requested a review from buenaflor November 18, 2024 16:09
@denrase denrase changed the title dos(flutter): Use sentry flutter init in samples docs(flutter): Use sentry flutter init in samples Nov 18, 2024
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, I think we can improve the code snippets in general to reduce the size of the snippets

platform-includes/configuration/allow-urls/flutter.mdx Outdated Show resolved Hide resolved
platform-includes/configuration/allow-urls/flutter.mdx Outdated Show resolved Hide resolved
platform-includes/configuration/allow-urls/flutter.mdx Outdated Show resolved Hide resolved
@denrase denrase requested a review from buenaflor November 18, 2024 16:48
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 4:15pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 4:15pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 4:15pm

@denrase
Copy link
Collaborator Author

denrase commented Nov 19, 2024

@buenaflor I noticed some formatting issues and one codeblock is still using Sentry.init. Will udate and notify you.

@denrase denrase disabled auto-merge November 19, 2024 14:29
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add comment everywhere but if possible inline the callbacks to make the code snippets a bit more digestible

@denrase
Copy link
Collaborator Author

denrase commented Nov 25, 2024

@buenaflor Updated and i also updated the dart samples where we added flutter

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last change, let's make the code a bit more readable but reducing the newlines a bit, pls do it everywhere else as well 🙏

platform-includes/configuration/sample-rate/dart.mdx Outdated Show resolved Hide resolved
platform-includes/performance/traces-sample-rate/dart.mdx Outdated Show resolved Hide resolved
platform-includes/set-fingerprint/basic/dart.mdx Outdated Show resolved Hide resolved
@denrase
Copy link
Collaborator Author

denrase commented Nov 25, 2024

@buenaflor Now we should have the same rules applied to most of the dart/flutter samples. We should klick all of them through when vercel is deployed to see whether everything works as expected.

@buenaflor
Copy link
Contributor

@denrase preview is deployed

@denrase denrase enabled auto-merge (squash) November 26, 2024 15:56
@denrase denrase merged commit 69bd829 into getsentry:master Nov 26, 2024
10 checks passed
martinhaintz pushed a commit that referenced this pull request Nov 27, 2024
…ierarchy

* master: (28 commits)
  feat(angular): Update SDK provider setup for Angular 19 (#11921)
  feat(dynamic-sampling): adapt docs to new dynamic sampling logic (#11886)
  update banner for post-launch week promotion (#11964)
  chore(android): Add masking options to AndroidManifest (#11863)
  Bump API schema to 2126f7dd (#11965)
  chore(Profiling): Add callouts and links to Android Profiling troubleshooting info (#11905)
  docs(flutter): Use sentry flutter init in samples (#11858)
  use native crypto to generate uuid (#11959)
  fix vercel integration 404 (#11958)
  Add RN Replay Privacy page (#11798)
  feat(dashboards): Add docs for Dashboard Edit Access Selector (#11822)
  feat(app-starts): Add RN SDK min version (#11650)
  feat(realy): Add Relay best practices guide (#11914)
  docs(sdks): New Scope APIs (#11943)
  docs(sdks): Span Sampling (#11940)
  Add include explaining sample code options (#11866)
  devenv: internal troubleshooting (#11947)
  Bump API schema to 0b18bfae (#11946)
  Bump API schema to 2bee5317 (#11945)
  feat: Link to Replay Issues when we mention Perf Issues as well (#11933)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants