-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(flutter): Use sentry flutter init in samples #11858
docs(flutter): Use sentry flutter init in samples #11858
Conversation
@denrase is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, I think we can improve the code snippets in general to reduce the size of the snippets
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
@buenaflor I noticed some formatting issues and one codeblock is still using Sentry.init. Will udate and notify you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add comment everywhere but if possible inline the callbacks to make the code snippets a bit more digestible
platform-includes/configuration/before-send-fingerprint/flutter.mdx
Outdated
Show resolved
Hide resolved
platform-includes/enriching-events/attach-viewhierarchy/flutter.mdx
Outdated
Show resolved
Hide resolved
@buenaflor Updated and i also updated the dart samples where we added flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last change, let's make the code a bit more readable but reducing the newlines a bit, pls do it everywhere else as well 🙏
platform-includes/enriching-events/attach-viewhierarchy/flutter.mdx
Outdated
Show resolved
Hide resolved
@buenaflor Now we should have the same rules applied to most of the dart/flutter samples. We should klick all of them through when vercel is deployed to see whether everything works as expected. |
@denrase preview is deployed |
…ierarchy * master: (28 commits) feat(angular): Update SDK provider setup for Angular 19 (#11921) feat(dynamic-sampling): adapt docs to new dynamic sampling logic (#11886) update banner for post-launch week promotion (#11964) chore(android): Add masking options to AndroidManifest (#11863) Bump API schema to 2126f7dd (#11965) chore(Profiling): Add callouts and links to Android Profiling troubleshooting info (#11905) docs(flutter): Use sentry flutter init in samples (#11858) use native crypto to generate uuid (#11959) fix vercel integration 404 (#11958) Add RN Replay Privacy page (#11798) feat(dashboards): Add docs for Dashboard Edit Access Selector (#11822) feat(app-starts): Add RN SDK min version (#11650) feat(realy): Add Relay best practices guide (#11914) docs(sdks): New Scope APIs (#11943) docs(sdks): Span Sampling (#11940) Add include explaining sample code options (#11866) devenv: internal troubleshooting (#11947) Bump API schema to 0b18bfae (#11946) Bump API schema to 2bee5317 (#11945) feat: Link to Replay Issues when we mention Perf Issues as well (#11933) ...
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
Add samples that use
SentryFlutter.init
instead ofSentry.init
.Relates to getsentry/sentry-dart#2383
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES