Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] Create docs for APM #1217

Closed
wants to merge 10 commits into from
Closed

[do not merge] Create docs for APM #1217

wants to merge 10 commits into from

Conversation

MimiDumpling
Copy link
Contributor

@MimiDumpling MimiDumpling commented Sep 11, 2019 •
edited by HazAT
Loading

Edit:
These docs live in our forums for now until we are confident to ship them:
https://forum.sentry.io/t/sentrys-apm-docs-alpha/7843

Sentry's new APM features need documentation. These docs will help with what we're currently offering.

image

Note: do not merge until beta release

@MimiDumpling MimiDumpling requested a review from HazAT September 11, 2019 21:35
MimiDumpling
MimiDumpling commented Sep 12, 2019
View reviewed changes
Copy link
Contributor Author

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few grammar things. 😸

src/collections/_documentation/workflow/apm/index.md Outdated Show resolved Hide resolved
src/collections/_documentation/workflow/apm/index.md Outdated Show resolved Hide resolved
@dashed
Copy link
Member

dashed commented Sep 16, 2019

@MimiDumpling looks great! 👍

@eurica
Copy link
Contributor

eurica commented Sep 17, 2019

An alpha shouldn’t be the first thing on our docs — let’s find a better home for this content for now

@dcramer
Copy link
Member

dcramer commented Sep 17, 2019

A few things:

  1. This should not be available publicly (it should be hidden in docs)
  2. It should be its own section, its unrelated to workflow. It's just like "Error Reporting"
  3. Needs clearly called out as alpha

@mitsuhiko mitsuhiko changed the title Create docs for APM [do not merge] Create docs for APM Sep 18, 2019
HazAT
HazAT requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a reject here so no one presses merge by accident.

@HazAT
Copy link
Member

HazAT commented Oct 11, 2019

These docs live in our forums for now until we are confident to ship them:
https://forum.sentry.io/t/sentrys-apm-docs-alpha/7843

@joshuarli joshuarli deleted the create/mimi-apm branch August 4, 2020 01:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed left review comments

@HazAT HazAT HazAT requested changes

@kamilogorek kamilogorek kamilogorek approved these changes

@markstory markstory Awaiting requested review from markstory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MimiDumpling @dashed @eurica @dcramer @HazAT @markstory @kamilogorek