Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/ Grammar and Spelling for Guides #1257

Merged
merged 9 commits into from
Oct 10, 2019
Merged

Update/ Grammar and Spelling for Guides #1257

merged 9 commits into from
Oct 10, 2019

Conversation

MimiDumpling
Copy link
Contributor

Ido made a great Guide inside of Docs. Just going through the content and doing some sprucing up.

@MimiDumpling MimiDumpling changed the title Update/ Grammar and Spelling for Guides WIP: Update/ Grammar and Spelling for Guides Oct 7, 2019
dashed
dashed previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MimiDumpling MimiDumpling reopened this Oct 8, 2019
@MimiDumpling
Copy link
Contributor Author

@dashed 😄 Thanks, but I'm still working through the content. Will also tag @idosun as a reviewer when I'm done.

@dashed dashed dismissed their stale review October 9, 2019 19:48

PR is still WIP.

@MimiDumpling MimiDumpling requested a review from idosun October 9, 2019 23:31
@MimiDumpling MimiDumpling changed the title WIP: Update/ Grammar and Spelling for Guides Update/ Grammar and Spelling for Guides Oct 9, 2019
@MimiDumpling MimiDumpling requested a review from dashed October 9, 2019 23:44
dashed
dashed approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MimiDumpling Looks good to me! 👍

@MimiDumpling MimiDumpling merged commit 63c61d8 into master Oct 10, 2019
@MimiDumpling MimiDumpling deleted the update/mimi-guides branch October 31, 2019 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

@idosun idosun Awaiting requested review from idosun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MimiDumpling @dashed