Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CDN integrations to JS pluggable integrations #3098

Merged
merged 14 commits into from
Feb 16, 2021
Merged

feat: Add CDN integrations to JS pluggable integrations #3098

merged 14 commits into from
Feb 16, 2021

Conversation

iker-barriocanal
Copy link
Contributor

Resolves #1249.

@iker-barriocanal
ref: Extract "How to Enable" JS configuration integration
a793a20
@iker-barriocanal
feat: Add CDN to "How to enable" in pluggable integrations for JS
e962250
@iker-barriocanal
ref: Extract "ExtractErrorData" JS configuration integration
3110e26
@iker-barriocanal
feat: Add CDN to "ExtraErrorData" in pluggable integrations for JS
e972e7b
@iker-barriocanal
feat: Add CDN scripts in "ExtraErrorData" in pluggable integrations f…
f6d4c98 
…or JS
@iker-barriocanal
feat: Extract "CaptureConsole" JS configuration integration and add C…
252a7a5 
…DN integration
@iker-barriocanal
feat: Add CDN integration for RewriteFrames in JavaScript
2727897
@iker-barriocanal
fix: Add correct source for packages
43ad889
@iker-barriocanal
feat: Add CDN integration for ReportingObserver in JavaScript
bf0d5b5
@iker-barriocanal
feat: Add CDN integration for Debug in JavaScript
d258fcd
@iker-barriocanal
ref: Use PlatformContent instead of hardcoding
42fbfd3
@iker-barriocanal
feat: Add Dedupe integration in JavaScript
579c97f
@vercel
Copy link

vercel bot commented Feb 15, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/p9el9lzve/sentry.dev
✅ Preview: https://sentry-docs-git-feat-integration-cdn.sentry.dev

HazAT
HazAT requested changes Feb 16, 2021
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we also add the code samples to the javascript tab?

@iker-barriocanal
feat: Add full JS source code for pluggable integrations
005847e 
Added full JS code for the following pluggable integrations:
- CaptureConsole
- Debug
- ExtraErrorData
- ReportingObserver
- RewriteFrames
@iker-barriocanal
fix: Rename ExtraErrorData configuration
4f27b61
HazAT
HazAT approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@iker-barriocanal iker-barriocanal merged commit 1316992 into master Feb 16, 2021
@iker-barriocanal iker-barriocanal deleted the feat/integration-cdn branch February 16, 2021 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HazAT HazAT HazAT approved these changes

@PeloWriter PeloWriter Awaiting requested review from PeloWriter

@rhcarvalho rhcarvalho Awaiting requested review from rhcarvalho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrations from CDN, SRI for integrations
2 participants
@iker-barriocanal @HazAT