Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dotnet embedded sources #6179

Merged
merged 3 commits into from
Feb 9, 2023
Merged

feat: dotnet embedded sources #6179

merged 3 commits into from
Feb 9, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jan 30, 2023

@vercel
Copy link

vercel bot commented Jan 30, 2023

@vaind is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vaind
Copy link
Collaborator Author

vaind commented Jan 30, 2023

cc @mattjohnsonpint

@vaind vaind force-pushed the feat/dotnet-embedded-sources branch from 53d7095 to 1d3408b Compare January 30, 2023 18:48
@mattjohnsonpint
Copy link
Contributor

Not sure if this advice is accurate in all cases anyway. On a brand-new .NET 7 console app, without EmbedAllSources set, Sentry-CLI is still finding sources in the pdb.

Oddly, I can't seem to test the inverse - trying to create a source bundle from actual source files doesn't seem to work. Not sure why.

@bruno-garcia
Copy link
Member

Not sure if this advice is accurate in all cases anyway. On a brand-new .NET 7 console app, without EmbedAllSources set, Sentry-CLI is still finding sources in the pdb.

I believe this is a bug in sentry-cli

lizokm
lizokm approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end.

src/platforms/common/data-management/debug-files/source-context.mdx Outdated Show resolved Hide resolved
@mattjohnsonpint
Copy link
Contributor

We'll need to rework this on top of the changes I made in #6183.

@bruno-garcia
Copy link
Member

@vaind bump

@vaind
Copy link
Collaborator Author

vaind commented Feb 8, 2023 •
edited
Loading

We'll need to rework this on top of the changes I made in #6183.

Want to pick this up then, @mattjohnsonpint ? You know best about the msbuild integration (or rather, I know next to nothing)

@mattjohnsonpint
Copy link
Contributor

Updated and expanded a bit. Thanks.

@vercel
Copy link

vercel bot commented Feb 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 2:17AM (UTC)

@mattjohnsonpint mattjohnsonpint merged commit 4950e3e into getsentry:master Feb 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@lizokm lizokm lizokm approved these changes

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaind @mattjohnsonpint @bruno-garcia @lizokm