-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve navigation structure #986
Conversation
dcramer
commented
May 16, 2019
- Auto expand most top level categories
- Bring design into alignment with readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
StyleAs a professional designer and person responsible for our brand, I'm not super thrilled about intentionally trying to copy Readme. May of these changes feel like personal taste rather than things that are objective improvements. I would presume there are ways to get the usability benefits without completely copying their flavor. Sidebar
Search in the headerI'm into it. I've wanted to go that direction. Is it intentional that the search doesn't work in mobile? MiscThere seems to be a handful of arbitrary formatting changes, a handful of which make things harder to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with feedback on design changes, but I don't want the docs to be design-y (for lack of better terms). I think Readme does an excellent job in terms of usability out of the box, better than we have done. I realize thats subjective, and I'm ok with that as basically most things in design will end up being subjective.
- Search should be hidden on mobile, which doesn't need to be a priority for docs.
- Formatting changes would be due to automated tools like Prettier.
@@ -49,4 +49,4 @@ $breadcrumb-margin-bottom: 0; | |||
$border-width: 2px; | |||
|
|||
$btn-font-size: 1rem; | |||
$btn-font-size-sm: 0.875rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized this wasn’t base don’t size will revert
- Auto expand most top level categories - Bring design into alignment with readme