-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve React docs #999
Conversation
src/collections/_documentation/platforms/javascript/getting-started-dsn/react.md
Show resolved
Hide resolved
@@ -4,17 +4,19 @@ sidebar_order: 30 | |||
--- | |||
<!-- WIZARD --> | |||
To use Sentry with your React application, you will need to use `@sentry/browser` (Sentry’s browser JavaScript SDK). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would insert the install/configure instructions here, then error boundaries comes after they're fully setup
3fdd3cc
to
b334156
Compare
b334156
to
be114db
Compare
Updated to remove version |
Jk my jsx is wrong |
To me this is an improvement if I stumble upon the React page itself, but something we should decide broadly: do we embed the setup docs on every framework, or should we just have a generic entry blurb that directs them to the core JavaScript setup. In some framework cases the setup will change so it can still make sense. |
Also trying to figure out how react.md can just include browsernpm.md to avoid copypasta, but it seems include_relative doesn't work based on the child file, but only the root template being rendered. |
No description provided.