Fixed Invalid index used in Debug logs (#3923)

* fix: correct log warning format for LogWarning * Update CHANGELOG.md --------- Co-authored-by: James Crosswell <[email protected]>
getsentry · Jan 31, 2025 · 2f818b2 · 2f818b2
1 parent 81452c1
commit 2f818b2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@
 ### Fixes
 
 - Fixed duplicate SentryMauiEventProcessors ([#3905](https://github.com/getsentry/sentry-dotnet/pull/3905))
+- Fixed invalid string.Format index in Debug logs for the DiagnosticSource integration ([#3923](https://github.com/getsentry/sentry-dotnet/pull/3923))
 
 ### Dependencies
 

diff --git a/src/Sentry.DiagnosticSource/Internal/DiagnosticSource/EFCommandDiagnosticSourceHelper.cs b/src/Sentry.DiagnosticSource/Internal/DiagnosticSource/EFCommandDiagnosticSourceHelper.cs
@@ -34,7 +34,7 @@ private static void SetCommandId(ISpan span, Guid? commandId)
                     span.Operation == Operation &&
                     TryGetCommandId(span) == commandId);
         }
-        Options.LogWarning("No correlation id found for {1}.", Operation);
+        Options.LogWarning("No correlation id found for {0}.", Operation);
         return null;
     }
 
@@ -49,6 +49,6 @@ protected override void SetSpanReference(ISpan span, object? diagnosticSourceVal
             }
             return;
         }
-        Options.LogWarning("No correlation id can be set for {1}.", Operation);
+        Options.LogWarning("No correlation id can be set for {0}.", Operation);
     }
 }
diff --git a/src/Sentry.DiagnosticSource/Internal/DiagnosticSource/EFConnectionDiagnosticSourceHelper.cs b/src/Sentry.DiagnosticSource/Internal/DiagnosticSource/EFConnectionDiagnosticSourceHelper.cs
@@ -22,7 +22,7 @@ internal EFConnectionDiagnosticSourceHelper(IHub hub, SentryOptions options) : b
                     span.Operation == Operation &&
                     TryGetConnectionId(span) == connectionId);
         }
-        Options.LogWarning("No correlation id found for {1}.", Operation);
+        Options.LogWarning("No correlation id found for {0}.", Operation);
         return null;
     }