-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better in app module allow list default #854
base: master
Are you sure you want to change the base?
Conversation
eeede8c
to
aa7273a
Compare
aa7273a
to
7c2ce0e
Compare
7c2ce0e
to
901d184
Compare
so if I understand correctly, the user will still have to supply these values? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge this but let's also please make the ootb experience possible
No, the user would only have to provide names of applications that should be considered when auto-discovering the modules. For example if you're building an app called Blog and there's a corresponding |
yes but that's still manual, why cannot we just detect a project root like other SDKs? we want good default ootb stacktraces |
@sl0thentr0py due to Elixir limitations, it cannot provide us with this information in a released Elixir app, so it does work in dev env, but not released prod. |
okay but from here
all the apps are already in the mix config, why do we ask for them again in a separate config? |
It's explained here #854 (comment) |
Co-authored-by: Andrea Leopardi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to mention the new option in :in_app_module_allow_list
too
This adds
otp_apps
config option which is then used to auto-discover module names for thein_app_module_allow_list
option.Closes #800