-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement flush with context #935
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 83.64% 83.39% -0.26%
==========================================
Files 49 49
Lines 5129 5154 +25
==========================================
+ Hits 4290 4298 +8
- Misses 682 700 +18
+ Partials 157 156 -1 ☔ View full report in Codecov by Sentry. |
The only thing failing here is the coverage. Do I have to 'fix' it or we can merge as-is? |
Do we have docs for this? |
No. Should I add it in |
Yes |
Resolves #746