-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Send replay recording options #4015
Conversation
…at/session-replay-recording-options
Performance metrics 🚀
|
...-android-replay/src/test/java/io/sentry/android/replay/capture/SessionCaptureStrategyTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
assertEquals(true, optionsEvent[0].optionsPayload["maskAllText"]) | ||
assertEquals(false, optionsEvent[0].optionsPayload["maskAllImages"]) | ||
assertEquals("high", optionsEvent[0].optionsPayload["quality"]) | ||
assertEquals("android.widget.TextView,android.webkit.WebView,android.widget.VideoView,androidx.media3.ui.PlayerView,com.google.android.exoplayer2.ui.PlayerView,com.google.android.exoplayer2.ui.StyledPlayerView,my.custom.View", optionsEvent[0].optionsPayload["maskedViewClasses"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIU from your definition of optionsPayload value, we could add a list here instead of a concatenated string. Would it make sense to do this by default so we can potentially have a better UI for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…at/session-replay-recording-options
📜 Description
💡 Motivation and Context
Part of getsentry/sentry#74441
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
From the hybrid's side it's possible to intercept and change this event in their favour as follows: