Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log debug messages giving info about OpenTelemetry related config settings #4122

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

adinauer
Copy link
Member

Log debug messages giving info about OpenTelemetry related config settings

📜 Description

example output

DEBUG: openTelemetryMode has been inferred from AUTO to AGENT
INFO: Initializing SDK with DSN: 'https://[email protected]/5428563'
...
DEBUG: Using openTelemetryMode AGENT
DEBUG: Using span factory io.sentry.opentelemetry.OtelSpanFactory
DEBUG: Using scopes storage io.sentry.opentelemetry.OtelContextScopesStorage
...

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7c07d74

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 463.83 ms 500.16 ms 36.33 ms
Size 1.65 MiB 2.31 MiB 678.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: feat/log-otel-config

Startup times

Revision Plain With Sentry Diff
8a8a7eb 437.18 ms 523.50 ms 86.32 ms

App size

Revision Plain With Sentry Diff
8a8a7eb 1.65 MiB 2.31 MiB 678.22 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit b68011a into main Jan 30, 2025
37 checks passed
@adinauer adinauer deleted the feat/log-otel-config branch January 30, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants