-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(v8/deps): Deduplicate yarn.lock (#15094)
The `use-ts-version` script was only ever used for TypeScript 3.8, so to keep things simple, I copied back the entire script and its usage from the `develop` branch. --------- Co-authored-by: Abhijeet Prasad <[email protected]>
- Loading branch information
1 parent
8b870ba
commit 5f47fbb
Showing
5 changed files
with
294 additions
and
2,760 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* eslint-disable no-console */ | ||
const { execSync } = require('child_process'); | ||
const { join } = require('path'); | ||
const { readFileSync, writeFileSync } = require('fs'); | ||
|
||
const cwd = join(__dirname, '../../..'); | ||
|
||
// Newer versions of the Express types use syntax that isn't supported by TypeScript 3.8. | ||
// We'll pin to the last version of those types that are compatible. | ||
console.log('Pinning Express types to old versions...'); | ||
|
||
const packageJsonPath = join(cwd, 'package.json'); | ||
const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8')); | ||
|
||
if (!packageJson.resolutions) packageJson.resolutions = {}; | ||
packageJson.resolutions['@types/express'] = '4.17.13'; | ||
packageJson.resolutions['@types/express-serve-static-core'] = '4.17.30'; | ||
|
||
writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2)); | ||
|
||
const tsVersion = '3.8'; | ||
|
||
console.log(`Installing typescript@${tsVersion}, and @types/node@14...`); | ||
|
||
execSync(`yarn add --dev --ignore-workspace-root-check typescript@${tsVersion} @types/node@^14`, { | ||
stdio: 'inherit', | ||
cwd, | ||
}); | ||
|
||
console.log('Removing unsupported tsconfig options...'); | ||
|
||
const baseTscConfigPath = join(cwd, 'packages/typescript/tsconfig.json'); | ||
|
||
const tsConfig = require(baseTscConfigPath); | ||
|
||
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :( | ||
delete tsConfig.compilerOptions.noUncheckedIndexedAccess; | ||
|
||
writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2)); |
23 changes: 0 additions & 23 deletions
23
dev-packages/node-integration-tests/scripts/use-ts-version.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.