Skip to content

Commit

Permalink
ref: Remove Repo interface and repos attribute from Event (#1598)
Browse files Browse the repository at this point in the history
  • Loading branch information
kamilogorek authored Sep 28, 2018
1 parent 89885fa commit 72a8bce
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 16 deletions.
6 changes: 1 addition & 5 deletions packages/core/src/baseclient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
* @returns A new event with more information.
*/
protected async prepareEvent(event: SentryEvent, scope?: Scope, hint?: SentryEventHint): Promise<SentryEvent | null> {
const { environment, maxBreadcrumbs = DEFAULT_BREADCRUMBS, release, repos, dist } = this.getOptions();
const { environment, maxBreadcrumbs = DEFAULT_BREADCRUMBS, release, dist } = this.getOptions();

const prepared = { ...event };
if (prepared.environment === undefined && environment !== undefined) {
Expand All @@ -284,10 +284,6 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
prepared.release = release;
}

if (prepared.repos === undefined && repos !== undefined) {
prepared.repos = repos;
}

if (prepared.dist === undefined && dist !== undefined) {
prepared.dist = dist;
}
Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@ export interface Options {
/** The current environment of your application (e.g. "production"). */
environment?: string;

/** Configures the repository spec for events */
repos?: Record<string, Repo>;

/** Sets the distribution for all events */
dist?: string;

Expand Down
8 changes: 0 additions & 8 deletions packages/types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,6 @@ export interface Request {
headers?: { [key: string]: string };
}

/** JSDoc */
export interface Repo {
name: string;
prefix?: string;
revision?: string;
}

/** JSDoc */
export interface SentryEvent {
event_id?: string;
Expand All @@ -172,7 +165,6 @@ export interface SentryEvent {
logger?: string;
server_name?: string;
release?: string;
repos?: Record<string, Repo>,
dist?: string;
environment?: string;
sdk?: SdkInfo;
Expand Down

0 comments on commit 72a8bce

Please sign in to comment.