Skip to content

Commit

Permalink
fix: Events created from exception shouldnt have top-level message at…
Browse files Browse the repository at this point in the history
…tribute (#1831)
  • Loading branch information
kamilogorek authored and HazAT committed Mar 19, 2019
1 parent d9bb595 commit 7e378da
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
16 changes: 15 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
# Changelog

## Unreleased
## v5

### Migration from v4

This major bump brings a lot of internal improvements. If you were using the SDK without any special abilities,
basically, the way we describe it in the docs, you should be fine by just updating it. This is a **breaking** release
since we removed some methods from the public API and removed some classes from the default export.

- **breaking** [node] fix: Events created from exception shouldn't have top-level message attribute
- [utils] ref: Update wrap method to hide internal sentry flags
- [utils] fix: Make internal Sentry flags non-enumerable in fill util
- [utils] ref: Move `SentryError` + `PromiseBuffer` to utils
- **breaking** [core] ref: Use `SyncPromise` internally, this reduces memory pressure by a lot.
- **breaking** [browser] ref: Removed `BrowserBackend` from default export.
- **breaking** [node] ref: Removed `BrowserBackend` from default export.

## 4.6.4

Expand Down
2 changes: 0 additions & 2 deletions packages/node/src/parsers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,11 @@ export async function getExceptionFromError(error: Error, options?: NodeOptions)

/** JSDoc */
export async function parseError(error: ExtendedError, options?: NodeOptions): Promise<SentryEvent> {
const name = error.name || error.constructor.name;
const exception = await getExceptionFromError(error, options);
return {
exception: {
values: [exception],
},
message: `${name}: ${error.message || '<no message>'}`,
};
}

Expand Down

0 comments on commit 7e378da

Please sign in to comment.