Skip to content

Commit

Permalink
fix(replay): Temporarily build Replay after other packages (#6307)
Browse files Browse the repository at this point in the history
Fix a build error in Replay's build process by building it after all other packages (including their type declarations) were built. We have to do this temporarily because `@rollup/plugin-typescript` expects type declarations of the `@sentry/*` dependencies of the replay package. Because we're building types in parallel to transpiling JS, type declarations were not yet (reliably) built before replay's `build:rollup` commands was executed.

To unblock us, we for now build the package via `build:extras` so that it only runs after all other packages were fully built.

We should revert this change as soon as we use our transpilation process (sucrase) where we don't care about type declarations.

This might also fix the size-limit action on the master branch.
  • Loading branch information
Lms24 authored Nov 25, 2022
1 parent 80e0599 commit b49082e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/replay/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"sideEffects": false,
"scripts": {
"bootstrap": "yarn && cd demo && yarn #TODO: change after migration",
"build": "yarn build:rollup",
"build:rollup": "NODE_ENV=production yarn build:all",
"build": "yarn build:extras",
"build:extras": "NODE_ENV=production yarn build:all",
"build:dev": "NODE_ENV=development yarn build:all",
"build:all": "run-s clean build:worker build:core",
"build:core": "yarn build:actualRollup --config config/rollup.config.core.ts",
Expand Down

0 comments on commit b49082e

Please sign in to comment.