test(e2e): Unflake sveltekit e2e tests (#11597)

getsentry · Apr 15, 2024 · d75b9af · d75b9af
1 parent 2e7c4f4
commit d75b9af
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts
@@ -4,17 +4,17 @@ import { waitForInitialPageload } from './utils';
 
 test.describe('client-side errors', () => {
   test('captures error thrown on click', async ({ page }) => {
-    await page.goto('/client-error');
-
-    await expect(page.getByText('Client error')).toBeVisible();
+    await waitForInitialPageload(page, { route: '/client-error', debug: false });
 
     const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
       return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
     });
 
-    const clickPromise = page.getByText('Throw error').click();
+    await page.getByText('Throw error').click();
+
+    await expect(errorEventPromise).resolves.toBeDefined();
 
-    const [errorEvent, _] = await Promise.all([errorEventPromise, clickPromise]);
+    const errorEvent = await errorEventPromise;
 
     const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;
 

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts
@@ -4,17 +4,17 @@ import { waitForInitialPageload } from '../utils';
 
 test.describe('client-side errors', () => {
   test('captures error thrown on click', async ({ page }) => {
-    await page.goto('/client-error');
-
-    await expect(page.getByText('Client error')).toBeVisible();
+    await waitForInitialPageload(page, { route: '/client-error', debug: false });
 
     const errorEventPromise = waitForError('sveltekit', errorEvent => {
       return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
     });
 
-    const clickPromise = page.getByText('Throw error').click();
+    await page.getByText('Throw error').click();
+
+    await expect(errorEventPromise).resolves.toBeDefined();
 
-    const [errorEvent, _] = await Promise.all([errorEventPromise, clickPromise]);
+    const errorEvent = await errorEventPromise;
 
     const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;