only delete replay tests, more debugging

getsentry · Feb 28, 2023 · e3edf79 · e3edf79
1 parent 8092f21
commit e3edf79
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/packages/integration-tests/suites/replay/privacyInput/test.ts b/packages/integration-tests/suites/replay/privacyInput/test.ts
@@ -40,13 +40,11 @@ sentryTest('should mask input initial value and its changes', async ({ getLocalT
   const text = 'test';
 
   page.on('console', message => console.log(message.text()))
-  const input = page.locator('#input');
-  await input.press('t')
-  await input.press('e')
-  await input.press('s')
-  await input.press('t')
+  await page.locator('#input').type(text);
   console.log('input value: ', await page.locator('#input').inputValue());
+  console.log('before force flush', new Date().getTime())
   await forceFlushReplay();
+  console.log('after force flush', new Date().getTime())
   const allSnapshots = getIncrementalRecordingSnapshots(await reqPromise1);
   const snapshots = allSnapshots.filter(isInputMutation);
   const lastSnapshot = snapshots[snapshots.length - 1];

diff --git a/packages/replay/src/coreHandlers/handleScope.ts b/packages/replay/src/coreHandlers/handleScope.ts
@@ -48,8 +48,5 @@ export function handleScope(scope: Scope): Breadcrumb | null {
     return null;
   }
 
-  // eslint-disable-next-line
-  console.log({newBreadcrumb})
-
   return createBreadcrumb(newBreadcrumb);
 }
diff --git a/packages/replay/src/replay.ts b/packages/replay/src/replay.ts
@@ -1,5 +1,5 @@
 /* eslint-disable max-lines */ // TODO: We might want to split this file up
-import { EventType, record } from '@sentry-internal/rrweb';
+import { EventType, IncrementalSource, record } from '@sentry-internal/rrweb';
 import { captureException, getCurrentHub } from '@sentry/core';
 import type { Breadcrumb, ReplayRecordingMode } from '@sentry/types';
 import { logger } from '@sentry/utils';
@@ -203,6 +203,7 @@ export class ReplayContainer implements ReplayContainerInterface {
         // Without this, it would record forever, until an error happens, which we don't want
         // instead, we'll always keep the last 60 seconds of replay before an error happened
         ...(this.recordingMode === 'error' && { checkoutEveryNms: ERROR_CHECKOUT_TIME }),
+        recordCrossOriginIframes: true,
         emit: this._handleRecordingEmit,
       });
     } catch (err) {
@@ -528,6 +529,10 @@ export class ReplayContainer implements ReplayContainerInterface {
       return;
     }
 
+    if (event.type === EventType.IncrementalSnapshot && event.data.source === IncrementalSource.Input) {
+      console.log(JSON.stringify(event));
+    }
+
     this.addUpdate(() => {
       // The session is always started immediately on pageload/init, but for
       // error-only replays, it should reflect the most recent checkout
@@ -795,7 +800,7 @@ export class ReplayContainer implements ReplayContainerInterface {
       // Note this empties the event buffer regardless of outcome of sending replay
       const recordingData = await this.eventBuffer.finish();
 
-      console.log('RUNNING FLUSH')
+      console.log('RUNNING FLUSH', new Date().getTime())
       // NOTE: Copy values from instance members, as it's possible they could
       // change before the flush finishes.
       const replayId = this.session.id;