Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): Export sendFeedback from @sentry/browser #10231

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 17, 2024

We forgot to re-export this when we re-exported Feedback from the browser SDK. This makes it easier to use than exposing sendFeedback via the Feedback integration instance itself.

We forgot to re-export this when we re-exported `Feedback` from the browser SDK. This makes it easier to use than exposing `sendFeedback` via the Feedback integration instance itself.
Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.52 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.8 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.68 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.43 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.8 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.48 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.72 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.58 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.19 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.25 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.22 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.62 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.2 KB (0%)
@sentry/react - Webpack (gzipped) 22.52 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.79 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.93 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.12 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.14 KB (added)

@billyvg
Copy link
Member Author

billyvg commented Jan 17, 2024

Ugh same issue as #10112 -- it's including the entire Feedback package even though we are importing sendFeedback.

@billyvg billyvg marked this pull request as ready for review January 17, 2024 22:01
@mydea
Copy link
Member

mydea commented Jan 18, 2024

Ugh same issue as #10112 -- it's including the entire Feedback package even though we are importing sendFeedback.

Is this not expected? 🤔 Does sendFeedback not need the whole feedback code?

@billyvg
Copy link
Member Author

billyvg commented Jan 18, 2024

Ugh same issue as #10112 -- it's including the entire Feedback package even though we are importing sendFeedback.

Is this not expected? 🤔 Does sendFeedback not need the whole feedback code?

It shouldn't, it's only the API, the rest of the feedback code is related to the UI.

@billyvg billyvg merged commit b6e84dc into develop Jan 18, 2024
94 checks passed
@billyvg billyvg deleted the feat-feedback-reexport-sendFeedback branch January 18, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants