-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add metric summaries to spans #10554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cleptric
commented
Feb 7, 2024
•
edited
Loading
edited
![image](https://private-user-images.githubusercontent.com/6617432/303373866-3df80bcb-26b5-47d3-891e-7df0ffedaacb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTg5NzIsIm5iZiI6MTczOTU5ODY3MiwicGF0aCI6Ii82NjE3NDMyLzMwMzM3Mzg2Ni0zZGY4MGJjYi0yNmI1LTQ3ZDMtODkxZS03ZGYwZmZlZGFhY2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDU1MTEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjQyMDQ5ZDc5NWE5NjBlNTgzZWViM2QwNWNiMjg5NDk1MDFjZGJkOTdmZjE5ZjZiNDM4MTRhOTBkYjVkOGNjNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.66HfLiD0j3-zaCR3hcBM76v5LsmXa19vDbp7trxByVQ)
- Fix tag normalization, which now allows whitespace for tag values, and remove the wrongly added replacement character for tag values; see https://develop.sentry.dev/sdk/metrics/#normalization
b7afcc4
to
f00464a
Compare
size-limit report 📦
|
d6da2ac
to
858b9bd
Compare
AbhiPrasad
reviewed
Feb 8, 2024
@cleptric there's some formatting issues, mind running |
I ended up pushing Going to merge it in now! |
AbhiPrasad
approved these changes
Feb 12, 2024
AbhiPrasad
added a commit
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Abhijeet Prasad <[email protected]>
This was referenced Feb 14, 2024
This was referenced Mar 12, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.