Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add metric summaries to spans #10554

Merged
merged 12 commits into from
Feb 12, 2024
Merged

feat(core): Add metric summaries to spans #10554

merged 12 commits into from
Feb 12, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Feb 7, 2024

image

@cleptric cleptric self-assigned this Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.95 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.18 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.11 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.79 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.37 KB (+0.3% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.23 KB (+0.31% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (+0.07% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.08% 🔺)
@sentry/browser - Webpack (gzipped) 22.43 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.09 KB (+0.38% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.6 KB (+0.35% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.59 KB (+0.77% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.64 KB (+0.86% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.93 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.55 KB (+0.59% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.83 KB (+0.61% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.83 KB (+0.75% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.55 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped) 22.46 KB (+0.09% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.34 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.45 KB (+0.14% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (+0.01% 🔺)

@cleptric cleptric marked this pull request as ready for review February 8, 2024 13:50
@cleptric cleptric requested review from a team, stephanie-anderson and AbhiPrasad and removed request for a team, stephanie-anderson and AbhiPrasad February 8, 2024 13:50
@AbhiPrasad AbhiPrasad changed the title Metrics summary feat(core): Add metric summaries to spans Feb 8, 2024
@AbhiPrasad AbhiPrasad requested a review from timfish February 12, 2024 14:23
@AbhiPrasad
Copy link
Member

@cleptric there's some formatting issues, mind running yarn fix and pushing?

@AbhiPrasad
Copy link
Member

I ended up pushing yarn fix to 1b32bc5

Going to merge it in now!

@AbhiPrasad AbhiPrasad merged commit 860dd2f into develop Feb 12, 2024
95 checks passed
@AbhiPrasad AbhiPrasad deleted the metrics-summary branch February 12, 2024 15:16
AbhiPrasad added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants