-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs/v7): Support Hybrid Cloud DSNs with tunnelRoute
option
#10958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
feat(nextjs): Support Hybrid Cloud DSNs with
feat(nextjs/v7): Support Hybrid Cloud DSNs with Mar 7, 2024
tunnelRoute
optiontunnelRoute
option
mydea
approved these changes
Mar 7, 2024
size-limit report 📦
|
Closed
oioki
reviewed
Mar 7, 2024
Co-authored-by: Alexander Tarasov <[email protected]>
AbhiPrasad
approved these changes
Mar 7, 2024
This was referenced Mar 12, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10948
The new Hybrid Cloud DSNs are incompatible with the
tunnelRoute
option. This PR adds some extra matching to support the new DSNs including the region code.It is paramount that we check for the pattern of the passed query params in the Next.js rewrite matcher to avoid any sort of SSRF.