Also copy function properties while wrapping function #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| for (property in func) { | ||
| wrappedFunction[property] = func[property]; |
There was a problem hiding this comment.
Wouldn't you want to check the hasOwnProperty thing here before doing this?
Like: func.hasOwnProperty(property) && wrappedFunction[property] = func[property];
|
lgtm |
mattrobenolt
added a commit
that referenced
this pull request
Aug 24, 2013
Also copy function properties while wrapping function
billyvg
added a commit
that referenced
this pull request
Dec 12, 2023
> * Revert "fix: isCheckout is not included in fullsnapshot event (rrweb-io#1141)" Fixes an issue where Meta event is being lost in buffered replays. > revert: feat: Remove plugins related code, which is not used #123 > feat: Export additional canvas-related types and functions (#134) Changes needed for canvas playback > feat: Skip addHoverClass when stylesheet is >= 1MB #130 Affects playback only
billyvg
added a commit
that referenced
this pull request
Dec 12, 2023
> * Revert "fix: isCheckout is not included in fullsnapshot event (rrweb-io#1141)" Fixes an issue where Meta event is being lost in buffered replays. > revert: feat: Remove plugins related code, which is not used #123 > feat: Export additional canvas-related types and functions (#134) Changes needed for canvas playback > feat: Skip addHoverClass when stylesheet is >= 1MB #130 Affects playback only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I had some problems with wrapping define and require by require.js lately. Internally require.js sets:
When wrapping the function this property gets not copied which caused some problems because it's very common to check for it to define AMD modules when available. Even jQuery itself does it:
I'm not sure if my way of just copying the properties is the best way but I'm open for suggestions.