Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow capture of more than 1 ANR event #14684

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: Allow capture of more than 1 ANR event #14684

merged 2 commits into from
Dec 13, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 12, 2024 •
edited
Loading

Adds a maxAnrEvents option to the ANR integration which allows you to capture more than one event.

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
210 1 209 9
View the top 1 failed tests by shortest run time 
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time 
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

AbhiPrasad
AbhiPrasad reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this please, I want to make sure this doesn't regress

@timfish timfish requested a review from AbhiPrasad December 13, 2024 15:46
AbhiPrasad
AbhiPrasad approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also backport this to v8 as well

@timfish timfish mentioned this pull request Dec 13, 2024
Merged
@AbhiPrasad AbhiPrasad merged commit 33b3b23 into develop Dec 13, 2024
158 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/feat/anr-multiple branch December 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ANR only sends one event
2 participants
@timfish @AbhiPrasad