Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: Remove getDomElement method #14797

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 19, 2024

I noticed this in #14758, this seems unnecessary and all browsers/envs we support should be able to handle this. We only use this in two places anyhow, so we can just guard there (a bit) for this instead.

I will add a deprecation to v8 for this too, although this is just exported from core and will most likely not affect anybody.

@mydea mydea requested review from lforst and AbhiPrasad December 19, 2024 09:42
@mydea mydea self-assigned this Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.13 KB - -
@sentry/browser - with treeshaking flags 21.81 KB - -
@sentry/browser (incl. Tracing) 35.61 KB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.88 KB -0.02% -9 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.29 KB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.29 KB -0.01% -6 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.68 KB -0.01% -4 B 🔽
@sentry/browser (incl. Feedback) 39.88 KB - -
@sentry/browser (incl. sendFeedback) 27.74 KB - -
@sentry/browser (incl. FeedbackAsync) 32.5 KB - -
@sentry/react 25.86 KB - -
@sentry/react (incl. Tracing) 38.48 KB -0.01% -1 B 🔽
@sentry/vue 27.36 KB - -
@sentry/vue (incl. Tracing) 37.5 KB -0.01% -1 B 🔽
@sentry/svelte 23.29 KB -0.08% -17 B 🔽
CDN Bundle 24.21 KB - -
CDN Bundle (incl. Tracing) 35.77 KB +0.03% +9 B 🔺
CDN Bundle (incl. Tracing, Replay) 70.87 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.17 KB -0.01% -4 B 🔽
CDN Bundle - uncompressed 71.09 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.56 KB -0.05% -51 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.63 KB -0.03% -51 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.83 KB -0.03% -51 B 🔽
@sentry/nextjs (client) 38.76 KB +0.02% +6 B 🔺
@sentry/sveltekit (client) 36.15 KB -0.06% -20 B 🔽
@sentry/node 157.95 KB - -
@sentry/node - without tracing 98.84 KB -0.01% -1 B 🔽
@sentry/aws-serverless 126.57 KB -0.01% -1 B 🔽

View base workflow run

@mydea mydea merged commit 87dcdef into develop Dec 19, 2024
151 checks passed
@mydea mydea deleted the fn/remove-getDomElement branch December 19, 2024 11:34
mydea added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants