feat(solidstart): Add autoInjectServerSentry: 'experimental_dynamic-import
#14863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
s1gr1d
force-pushed
the
sig/solidstart-dynamic-import
branch
from
6616ad1 to
a13d2b6
Compare
andreiborza
reviewed
Jan 7, 2025
dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errorboundary.test.ts
Show resolved
Hide resolved
Comment on lines
24
to
26
| if (options.autoInjectServerSentry !== 'experimental_dynamic-import') { | ||
| sentryPlugins.push(makeBuildInstrumentationFilePlugin(options)); | ||
| } |
There was a problem hiding this comment.
m: I left this comment on the other PR as well, just to ensure we don't forget about it here: We copy the release injection files now, so we should add the plugin in a way that the instrumentation file also gets injected with debug ids.
s1gr1d
force-pushed
the
sig/solidstart-dynamic-import
branch
from
a13d2b6 to
5ff2f0f
Compare
…instrumentation files
s1gr1d
force-pushed
the
ab/solidstart-withsentry
branch
from
0d73fd9 to
60dacf6
Compare
s1gr1d
force-pushed
the
ab/solidstart-withsentry
branch
from
60dacf6 to
333d210
Compare
s1gr1d
force-pushed
the
sig/solidstart-dynamic-import
branch
from
5ff2f0f to
f84bcf5
Compare
# Conflicts: # packages/solidstart/src/config/addInstrumentation.ts # packages/solidstart/src/config/withSentry.ts # packages/solidstart/src/vite/sentrySolidStartVite.ts # packages/solidstart/src/vite/types.ts # packages/solidstart/test/config/addInstrumentation.test.ts
3 tasks
s1gr1d
added a commit
that referenced
this pull request
Jan 22, 2025
…import` (#14863)⚠️ THIS PR IS BASED ON #14862 Adds the option to dynamically import the server config file. ```typescript // app.config.ts import { defineConfig } from '@solidjs/start/config'; import { sentrySolidStartVite, withSentry } from '@sentry/solidstart'; export default defineConfig(withSentry( { /* ... */ }, { autoInjectServerSentry: 'experimental_dynamic-import' }) ); ``` --------- Co-authored-by: Andrei Borza <[email protected]> (cherry picked from commit 38ff6eb)
s1gr1d
added a commit
that referenced
this pull request
Jan 23, 2025
…import` (#14863)⚠️ THIS PR IS BASED ON #14862 Adds the option to dynamically import the server config file. ```typescript // app.config.ts import { defineConfig } from '@solidjs/start/config'; import { sentrySolidStartVite, withSentry } from '@sentry/solidstart'; export default defineConfig(withSentry( { /* ... */ }, { autoInjectServerSentry: 'experimental_dynamic-import' }) ); ``` --------- Co-authored-by: Andrei Borza <[email protected]> (cherry picked from commit 38ff6eb)
s1gr1d
added a commit
that referenced
this pull request
Jan 23, 2025
…15135) Backport of #14862 and #14863 --------- Co-authored-by: Andrei Borza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to dynamically import the server config file.